Bugzilla – Attachment 76281 Details for
Bug 20972
If ISBN has 10 numbers only the first 9 numbers are used
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Signed off patch correcting ISBN extraction
0001-Bug-20972-If-ISBN-has-10-numbers-only-the-first-9-nu.patch (text/plain), 1.04 KB, created by
Colin Campbell
on 2018-06-22 13:52:09 UTC
(
hide
)
Description:
Signed off patch correcting ISBN extraction
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2018-06-22 13:52:09 UTC
Size:
1.04 KB
patch
obsolete
>From 197e41c248a388c470ef1fae95ce7d8818edbba1 Mon Sep 17 00:00:00 2001 >From: xljoha <johan.larsson@ub.gu.se> >Date: Thu, 21 Jun 2018 09:58:55 +0200 >Subject: [PATCH] Bug 20972: If ISBN has 10 numbers only the first 9 numbers > are used > >If ISBN has 10 numbers only the first 9 numbers are being added to the Edifact-message (PIA+5+3540556753:IB') > >This is caused by wrong positioning of capturing parentheses in a regular expression. > >Sponsored-by: Gothenburg University Library >Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> >--- > Koha/Edifact/Order.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Edifact/Order.pm b/Koha/Edifact/Order.pm >index ac63a94a9a..dcab51dede 100644 >--- a/Koha/Edifact/Order.pm >+++ b/Koha/Edifact/Order.pm >@@ -596,7 +596,7 @@ sub additional_product_id { > $product_id = $1; > $product_code = 'EN'; > } >- elsif ( $isbn_field =~ m/(\d{9})[Xx\d]/ ) { >+ elsif ( $isbn_field =~ m/(\d{9}[Xx\d])/ ) { > $product_id = $1; > $product_code = 'IB'; > } >-- >2.17.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20972
:
76225
|
76281
|
76290
|
76303
|
76304