From 8cb6e43074b56a9fad187f9aefba1695fe35e74d Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 26 Jun 2018 15:17:21 +0000 Subject: [PATCH] Bug 20999: Remove invalid 'style="block"' from OPAC templates This patch removes an invalid attribute from OPAC template markup. There should be no visible change to the OPAC. To test, apply the patch and confirm that the following pages still look correct when using various cover image sources: Coce, Amazon, Google: - Bibliographic detail page (opac-detail.pl) - The shelf browser - Catalog search results - Recent comments --- koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 6 +++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc index 161f279..2beeb73 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc @@ -48,7 +48,7 @@ [% IF ( GoogleJackets ) %] [% IF ( item.browser_normalized_isbn ) %] -
+
[% ELSE %] No cover image available [% END %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 7567a7c..106b647 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -88,7 +88,7 @@ [% END %] [% IF ( Koha.Preference('Coce') && Koha.Preference('CoceProviders') ) %] [% coce_id = normalized_ean || normalized_isbn %] -
+
[% END %] [% IF OpenLibraryCovers %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt index c30f330..161acf0 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt @@ -250,7 +250,7 @@ [% IF ( GoogleJackets ) %] [% IF ( SEARCH_RESULT.normalized_isbn ) %] - + [% ELSE %] No cover image available [% END %] @@ -259,7 +259,7 @@ [% IF ( Koha.Preference('Coce') && Koha.Preference('CoceProviders') ) %] [% coce_id = SEARCH_RESULT.normalized_ean || SEARCH_RESULT.normalized_isbn %] [% IF ( coce_id ) %] - + [% ELSE %] No cover image available [% END %] @@ -267,7 +267,7 @@ [% IF OpenLibraryCovers %] [% IF SEARCH_RESULT.normalized_isbn %] - + [% ELSE %] No cover image available [% END %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt index 1b40741..4112c71 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt @@ -135,7 +135,7 @@ [% IF ( GoogleJackets ) %] [% IF ( review.normalized_isbn ) %] -
+
[% ELSE %] No cover image available [% END %] -- 2.1.4