From 53b107be6052dfce842cfbc846b318d8437431d3 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Wed, 27 Jun 2018 11:59:35 +0200 Subject: [PATCH] Bug 17240: (followup 4) Allow processes that rely on background jobs run in Plack mode Items batch deletion failed because after action, unlike batch modification, items are not displayed so code must not call BuildItemsData(). --- tools/batchMod.pl | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/tools/batchMod.pl b/tools/batchMod.pl index 1fa621a..ee102ca 100755 --- a/tools/batchMod.pl +++ b/tools/batchMod.pl @@ -201,21 +201,23 @@ if ($op eq "action") { } if ( $completedJobID || !$runinbackground ) { # Once the job is done - # If we have a reasonable amount of items, we display them - if (scalar(@itemnumbers) <= ( C4::Context->preference("MaxItemsToDisplayForBatchDel") // 1000 ) ) { - $items_display_hashref=BuildItemsData(@itemnumbers); - } else { - # Else, we only display the barcode - my @simple_items_display = map { - my $itemnumber = $_; - my $item = Koha::Items->find($itemnumber); - { - itemnumber => $itemnumber, - barcode => $item ? ( $item->barcode // q{} ) : q{}, - biblionumber => $item ? $item->biblio->biblionumber : q{}, - }; - } @itemnumbers; - $template->param("simple_items_display" => \@simple_items_display); + unless ($del) { + # If we have a reasonable amount of items, we display them + if (scalar(@itemnumbers) <= ( C4::Context->preference("MaxItemsToDisplayForBatchDel") // 1000 ) ) { + $items_display_hashref=BuildItemsData(@itemnumbers); + } else { + # Else, we only display the barcode + my @simple_items_display = map { + my $itemnumber = $_; + my $item = Koha::Items->find($itemnumber); + { + itemnumber => $itemnumber, + barcode => $item ? ( $item->barcode // q{} ) : q{}, + biblionumber => $item ? $item->biblio->biblionumber : q{}, + }; + } @itemnumbers; + $template->param("simple_items_display" => \@simple_items_display); + } } if ($runinbackground) { -- 2.7.4