From ad9ad9379ac4ba96f73bc5a331ccc268e08e2d0a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Fri, 29 Jun 2018 11:09:41 +0300 Subject: [PATCH] Bug 21015: fix performance issue with C4::Members loading Koha::Schema ("use Koha::Schema;") takes significantly time as it loads almost a couple hundred classes. Koha::Database has done that already once and we can use it to get the ResultSet "Borrower" as well, so let's use that. This also make the code more unified because Koha::Database is used throughout the code instead of Koha::Schema. --- C4/Members.pm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/C4/Members.pm b/C4/Members.pm index a901a961bc..e0c597a4ea 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -46,7 +46,6 @@ use Koha::Holds; use Koha::List::Patron; use Koha::Patrons; use Koha::Patron::Categories; -use Koha::Schema; our (@ISA,@EXPORT,@EXPORT_OK,$debug); @@ -595,7 +594,7 @@ database column. =cut sub get_cardnumber_length { - my $borrower = Koha::Schema->resultset('Borrower'); + my $borrower = Koha::Database->new->schema->resultset('Borrower'); my $field_size = $borrower->result_source->column_info('cardnumber')->{size}; my ( $min, $max ) = ( 0, $field_size ); # borrowers.cardnumber is a nullable varchar(20) $min = 1 if C4::Context->preference('BorrowerMandatoryField') =~ /cardnumber/; -- 2.11.0