Bugzilla – Attachment 76578 Details for
Bug 21009
Max length of inputs on editing/adding items is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21009: Fix max length of inputs on editing/adding items
Bug-21009-Fix-max-length-of-inputs-on-editingaddin.patch (text/plain), 4.11 KB, created by
Jonathan Druart
on 2018-06-29 17:12:58 UTC
(
hide
)
Description:
Bug 21009: Fix max length of inputs on editing/adding items
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-06-29 17:12:58 UTC
Size:
4.11 KB
patch
obsolete
>From 037cde437a4c77ac1d91a9156b62dedd706f7a47 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 29 Jun 2018 14:09:07 -0300 >Subject: [PATCH] Bug 21009: Fix max length of inputs on editing/adding items > >There is a "max length" value you can define at framework level to >limit the size of the input. But it is not taken into account on the >add/edit item form. > >It is a regression that has been introduced by > commit 47d2de9c024bfb93d56184f298f334b20685cd86 > Bug 12176: Remove HTML from additem.pl > >max_length vs maxlength > >Test plan: >- Define a maximum length for an item subfield >- Add or edit an item >=> Without this patch the maxlength attribute of the inputs are not >defined (maxlength="") >=> With this fix you will see the maxlength attributes correctly set >with the value you defined in the framework > >Note: >We could/should set this value to the size of the DB column when mapped >For instance 952$u is mapped with items.uri, which is a varchar(255). >This length restriction should done at framework level >--- > cataloguing/additem.pl | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index 5cb0809991..f85a315432 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -224,7 +224,7 @@ sub generate_subfield_form { > $subfield_data{marc_value} = { > type => 'hidden', > id => $subfield_data{id}, >- maxlength => $subfield_data{max_length}, >+ maxlength => $subfield_data{maxlength}, > value => $value, > }; > } >@@ -243,7 +243,7 @@ sub generate_subfield_form { > $subfield_data{marc_value} = { > type => 'text_auth', > id => $subfield_data{id}, >- maxlength => $subfield_data{max_length}, >+ maxlength => $subfield_data{maxlength}, > value => $value, > authtypecode => $subfieldlib->{authtypecode}, > }; >@@ -263,7 +263,7 @@ sub generate_subfield_form { > $subfield_data{marc_value} = { > type => 'text_plugin', > id => $subfield_data{id}, >- maxlength => $subfield_data{max_length}, >+ maxlength => $subfield_data{maxlength}, > value => $value, > class => $class, > nopopup => $plugin->noclick, >@@ -274,7 +274,7 @@ sub generate_subfield_form { > $subfield_data{marc_value} = { > type => 'text', > id => $subfield_data{id}, >- maxlength => $subfield_data{max_length}, >+ maxlength => $subfield_data{maxlength}, > value => $value, > }; # supply default input form > } >@@ -283,7 +283,7 @@ sub generate_subfield_form { > $subfield_data{marc_value} = { > type => 'hidden', > id => $subfield_data{id}, >- maxlength => $subfield_data{max_length}, >+ maxlength => $subfield_data{maxlength}, > value => $value, > }; > } >@@ -291,7 +291,7 @@ sub generate_subfield_form { > $subfield_data{marc_value} = { > type => 'text', > id => $subfield_data{id}, >- maxlength => $subfield_data{max_length}, >+ maxlength => $subfield_data{maxlength}, > value => $value, > }; > } >@@ -319,7 +319,7 @@ sub generate_subfield_form { > $subfield_data{marc_value} = { > type => 'text', > id => $subfield_data{id}, >- maxlength => $subfield_data{max_length}, >+ maxlength => $subfield_data{maxlength}, > value => $value, > }; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21009
:
76578
|
76749
|
76751