@@ -, +, @@ items items.onloan has been cleared. --- C4/Circulation.pm | 1 + t/db_dependent/Circulation.t | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) --- a/C4/Circulation.pm +++ a/C4/Circulation.pm @@ -1817,6 +1817,7 @@ sub AddReturn { . Dumper($issue->unblessed) . "\n"; } else { $messages->{'NotIssued'} = $barcode; + ModItem({ onloan => undef }, $item->{biblionumber}, $item->{itemnumber}) if defined $item->{onloan}; # even though item is not on loan, it may still be transferred; therefore, get current branch info $doreturn = 0; # No issue, no borrowernumber. ONLY if $doreturn, *might* you have a $borrower later. --- a/t/db_dependent/Circulation.t +++ a/t/db_dependent/Circulation.t @@ -17,7 +17,7 @@ use Modern::Perl; -use Test::More tests => 118; +use Test::More tests => 119; use DateTime; use POSIX qw( floor ); @@ -2348,6 +2348,16 @@ subtest 'CanBookBeIssued | notforloan' => sub { # TODO test with AllowNotForLoanOverride = 1 }; +subtest 'AddReturn should clear items.onloan for unissued items' => sub { + plan tests => 1; + + t::lib::Mocks::mock_preference( "AllowReturnToBranch", 'anywhere' ); + my $item = $builder->build_object({ class => 'Koha::Items', value => { onloan => '2018-01-01' }}); + AddReturn( $item->barcode, $item->homebranch ); + $item->discard_changes; # refresh + is( $item->onloan, undef, 'AddReturn did clear items.onloan' ); +}; + $schema->storage->txn_rollback; $cache->clear_from_cache('single_holidays'); --