From 36e43c8ef0213af26afba27b9a8ee214246c5f87 Mon Sep 17 00:00:00 2001
From: Aleisha Amohia <aleishaamohia@hotmail.com>
Date: Wed, 4 Jul 2018 00:12:21 +0000
Subject: [PATCH] Bug 12365: [FOLLOW-UP] Adding maxlength attribute and popover

Test that you can't add a note of more than 100 characters.
Test notes with rules, notes are hidden by 'Click to view note' and the
popover correctly displays note.
---
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
index 0a10714..48dfd0a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
@@ -213,7 +213,11 @@
                                                             [% END %]
                                                         </td>
 							<td>[% rule.rentaldiscount %]</td>
-            <td>[% rule.note %]</td>
+                                                        <td>
+                                                            [% IF rule.note %]
+                                                                <a data-toggle="popover" title="Note" data-content="[% rule.note %]">Click to view note</a>
+                                                            [% ELSE %]&nbsp;[% END %]
+                                                        </td>
                                                         <td class="actions">
                                                           <a href="#" class="editrule btn btn-default btn-xs"><i class="fa fa-pencil"></i> Edit</a>
                                                           <a class="btn btn-default btn-xs delete" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete&amp;itemtype=[% rule.itemtype %]&amp;categorycode=[% rule.categorycode %]&amp;branch=[% rule.current_branch %]"><i class="fa fa-trash"></i> Delete</a>
@@ -314,7 +318,7 @@
                         </select>
                     </td>
                     <td><input type="text" name="rentaldiscount" id="rentaldiscount" size="2" /></td>
-                    <td><input type="text" name="note" id="note" size="15" value=""></td>
+                    <td><input type="text" name="note" id="note" size="15" value="" maxlength="100"></td>
                     <td class="actions">
                         <input type="hidden" name="branch" value="[% current_branch %]"/>
                         <button type="submit" class="btn btn-default btn-xs"><i class="fa fa-save"></i> Save</button>
@@ -767,6 +771,8 @@
         var MSG_CONFIRM_DELETE = _("Are you sure you want to delete this rule? This cannot be undone.");
 
         $(document).ready(function() {
+            $('[data-toggle="popover"]').popover();
+
             $(".delete").on("click",function(){
                 return confirmDelete(MSG_CONFIRM_DELETE);
             });
-- 
2.1.4