Bugzilla – Attachment 7669 Details for
Bug 3916
Batch Modify tool overwrites dropdown fields - no option for "no change"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed Off] Bug 3916 [follow-up] : Adding a default choice in every dropdown list, not only branches, to let the corresponding value unchanged
Signed-Off-Bug-3916-follow-up--Adding-a-default-ch.patch (text/plain), 1.40 KB, created by
Liz Rea
on 2012-02-16 01:26:36 UTC
(
hide
)
Description:
[Signed Off] Bug 3916 [follow-up] : Adding a default choice in every dropdown list, not only branches, to let the corresponding value unchanged
Filename:
MIME Type:
Creator:
Liz Rea
Created:
2012-02-16 01:26:36 UTC
Size:
1.40 KB
patch
obsolete
>From 5051206c0dd94e2eb994e3ff254457bbfca839b7 Mon Sep 17 00:00:00 2001 >From: Sophie Meynieux <sophie.meynieux@biblibre.com> >Date: Tue, 14 Feb 2012 14:38:25 +0100 >Subject: [PATCH] [Signed Off] Bug 3916 [follow-up] : Adding a default choice > in every dropdown list, not only branches, to let the > corresponding value unchanged >Content-Type: text/plain; charset="utf-8" > >Signed-off-by: Liz Rea <wizzyrea@gmail.com> >Patch works as advertised >--- > tools/batchMod.pl | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 94cfa69..440e516 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -340,12 +340,13 @@ foreach my $tag (sort keys %{$tagslib}) { > #---- "true" authorised value > } > else { >- push @authorised_values, "" unless ( $tagslib->{$tag}->{$subfield}->{mandatory} ); >+ push @authorised_values, ""; # unless ( $tagslib->{$tag}->{$subfield}->{mandatory} ); > $authorised_values_sth->execute( $tagslib->{$tag}->{$subfield}->{authorised_value} ); > while ( my ( $value, $lib ) = $authorised_values_sth->fetchrow_array ) { > push @authorised_values, $value; > $authorised_lib{$value} = $lib; > } >+ $value=""; > } > $subfield_data{marc_value} =CGI::scrolling_list( # FIXME: factor out scrolling_list > -name => "field_value", >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3916
:
2263
|
7650
| 7669