Bugzilla – Attachment 76717 Details for
Bug 21029
"Suspend until" in modal in staff patron account is not translatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21029: Make "Suspend until:" translatable
Bug-21029-Make-Suspend-until-translatable.patch (text/plain), 2.30 KB, created by
Marcel de Rooy
on 2018-07-06 07:53:54 UTC
(
hide
)
Description:
Bug 21029: Make "Suspend until:" translatable
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-07-06 07:53:54 UTC
Size:
2.30 KB
patch
obsolete
>From bc82f74db5e388dc7117b794a82a9811d1b34016 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 4 Jul 2018 14:55:14 -0300 >Subject: [PATCH] Bug 21029: Make "Suspend until:" translatable >Content-Type: text/plain; charset=utf-8 > >The label was part of the holds.js file. As .js files are never >translatable it needs to be moved to template level. > >Test plan: >- Place a hold on an item >- Go to the patron account >- Click on the Suspend button on the holds tab >- View the modal, the label before the date field "Suspend until:" is >now translatable. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc | 1 + > koha-tmpl/intranet-tmpl/prog/js/holds.js | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc >index e7c68d7..bd51329 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc >@@ -37,6 +37,7 @@ > var CANCEL = _("Cancel"); > var RESUME = _("Resume"); > var SUSPEND = _("Suspend"); >+ var SUSPEND_UNTIL = _("Suspend until:"); > var SUSPEND_HOLD_ON = _("Suspend hold on"); > var CLEAR_DATE_TO_SUSPEND_INDEFINITELY = _("Clear date to suspend indefinitely"); > var SUSPEND_HOLD_ERROR_DATE = _("Unable to suspend hold, invalid date"); >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index 46c826c..e3b68c1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -241,7 +241,7 @@ $(document).ready(function() { > <div class='modal-body'>\ > <input type='hidden' id='suspend-modal-reserve_id' name='reserve_id' />\ > \ >- <label for='suspend-modal-until'>Suspend until:</label>\ >+ <label for='suspend-modal-until'>" + SUSPEND_UNTIL + "</label>\ > <input name='suspend_until' id='suspend-modal-until' class='suspend-until' size='10' />\ > \ > <p/><a class='btn btn-link' id='suspend-modal-clear-date' >" + CLEAR_DATE_TO_SUSPEND_INDEFINITELY + "</a></p>\ >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21029
:
76697
|
76700
| 76717