Bugzilla – Attachment 76737 Details for
Bug 21046
ILSDI - AuthenticatePatron returns a wrong borrowernumber if cardnumber is empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21046: Return the correct borrowernumber when there is empty cardnumber(s)
Bug-21046-Return-the-correct-borrowernumber-when-t.patch (text/plain), 1.98 KB, created by
Alex Arnaud
on 2018-07-06 13:41:31 UTC
(
hide
)
Description:
Bug 21046: Return the correct borrowernumber when there is empty cardnumber(s)
Filename:
MIME Type:
Creator:
Alex Arnaud
Created:
2018-07-06 13:41:31 UTC
Size:
1.98 KB
patch
obsolete
>From 4f037d7317746a31496a2a5b11fdfad82dfc4e6b Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Fri, 6 Jul 2018 13:40:53 +0000 >Subject: [PATCH] Bug 21046: Return the correct borrowernumber when there is > empty cardnumber(s) > >Test plan: > - Use a patron with an empty cardnumber to authenticate with ILSDI > AuthenticatePatron > (cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=userid&password=pass), > - make sure you have other patron(s) with empty cardnumber and there > borrowernumber is > smaller than the one you authenticate with, > - you should get a wrong borrowernumber, > - apply this patch, > - test again, you should get the right one >--- > C4/ILSDI/Services.pm | 2 +- > t/db_dependent/ILSDI_Services.t | 8 ++++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > >diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm >index 158ff8e..5534d3c 100644 >--- a/C4/ILSDI/Services.pm >+++ b/C4/ILSDI/Services.pm >@@ -357,7 +357,7 @@ sub AuthenticatePatron { > my ($status, $cardnumber, $userid) = C4::Auth::checkpw( C4::Context->dbh, $username, $password ); > if ( $status ) { > # Get the borrower >- my $patron = Koha::Patrons->find( { cardnumber => $cardnumber } ); >+ my $patron = Koha::Patrons->find( { userid => $userid } ); > return { id => $patron->borrowernumber }; > } > else { >diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t >index d918e43..1eca594 100644 >--- a/t/db_dependent/ILSDI_Services.t >+++ b/t/db_dependent/ILSDI_Services.t >@@ -42,9 +42,17 @@ subtest 'AuthenticatePatron test' => sub { > > my $plain_password = 'tomasito'; > >+ $builder->build({ >+ source => 'Borrower', >+ value => { >+ cardnumber => undef, >+ } >+ }); >+ > my $borrower = $builder->build({ > source => 'Borrower', > value => { >+ cardnumber => undef, > password => Koha::AuthUtils::hash_password( $plain_password ) > } > }); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21046
:
76737
|
76806
|
76854