Bugzilla – Attachment 77099 Details for
Bug 13779
sessionID declared twice in C4::Auth::checkauth()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13779 - sessionID declared twice in C4::Auth::checkauth()
Bug-13779---sessionID-declared-twice-in-C4Authchec.patch (text/plain), 1.33 KB, created by
David Cook
on 2018-07-19 07:01:03 UTC
(
hide
)
Description:
Bug 13779 - sessionID declared twice in C4::Auth::checkauth()
Filename:
MIME Type:
Creator:
David Cook
Created:
2018-07-19 07:01:03 UTC
Size:
1.33 KB
patch
obsolete
>From e9cad68adbebef15a3685b129f3245a665e09863 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 19 Jul 2018 16:57:22 +1000 >Subject: [PATCH] Bug 13779 - sessionID declared twice in C4::Auth::checkauth() > >The bug is that $sessionID is declared twice in C4::Auth::checkauth(). >At the moment, this doesn't actually create a problem, because no >one seems to be using the $sessionID which is returned by checkauth(), >except in the case of opac/external/overdrive/auth.pl which skips >the second declartion as it doesn't require auth. > >This patch removes the redefining of the $sessionID variable. > >In terms of testing, try logging in with a username and password >and see if it works. The only risk this patch would pose is breaking >auth I would think, since nothing is actually using the return value >from checkauth() for $sessionID. >--- > C4/Auth.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 2731ff2512..ed2350d77f 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -943,7 +943,7 @@ sub checkauth { > $session->param( 'search_history', $anon_search_history ); > } > >- my $sessionID = $session->id; >+ $sessionID = $session->id; > C4::Context->_new_userenv($sessionID); > $cookie = $query->cookie( > -name => 'CGISESSID', >-- >2.13.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13779
:
77099
|
78452
|
78527
|
78528