Bugzilla – Attachment 77238 Details for
Bug 18887
Introduce new table 'circulation_rules', use for 'max_holds' rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18887: Use get_effective_rule instead of search
Bug-18887-Use-geteffectiverule-instead-of-search.patch (text/plain), 1.55 KB, created by
Jonathan Druart
on 2018-07-24 15:25:25 UTC
(
hide
)
Description:
Bug 18887: Use get_effective_rule instead of search
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-07-24 15:25:25 UTC
Size:
1.55 KB
patch
obsolete
>From dfacbc7133702d47befe420db3f6b4d59ebb5a5e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 24 Jul 2018 12:25:09 -0300 >Subject: [PATCH] Bug 18887: Use get_effective_rule instead of search > >--- > Koha/CirculationRules.pm | 4 ++++ > Koha/Template/Plugin/CirculationRules.pm | 4 ++-- > 2 files changed, 6 insertions(+), 2 deletions(-) > >diff --git a/Koha/CirculationRules.pm b/Koha/CirculationRules.pm >index 76dc63d8cf..d594c1d1e1 100644 >--- a/Koha/CirculationRules.pm >+++ b/Koha/CirculationRules.pm >@@ -50,6 +50,10 @@ sub get_effective_rule { > > croak q{No rule name passed in!} unless $rule_name; > >+ for my $v ( $branchcode, $categorycode, $itemtype ) { >+ $v = undef if $v and $v eq '*'; >+ } >+ > my $search_params; > $search_params->{rule_name} = $rule_name; > >diff --git a/Koha/Template/Plugin/CirculationRules.pm b/Koha/Template/Plugin/CirculationRules.pm >index cc1e9127af..d6c79c8c00 100644 >--- a/Koha/Template/Plugin/CirculationRules.pm >+++ b/Koha/Template/Plugin/CirculationRules.pm >@@ -30,14 +30,14 @@ sub Get { > $categorycode = undef if $categorycode eq q{}; > $itemtype = undef if $itemtype eq q{}; > >- my $rule = Koha::CirculationRules->search( >+ my $rule = Koha::CirculationRules->get_effective_rule( > { > branchcode => $branchcode, > categorycode => $categorycode, > itemtype => $itemtype, > rule_name => $rule_name, > } >- )->next(); >+ ); > > return $rule->rule_value if $rule; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18887
:
65233
|
65234
|
65235
|
65236
|
65237
|
67620
|
70986
|
70987
|
70988
|
70989
|
70990
|
70991
|
71031
|
71042
|
72218
|
72219
|
72220
|
72221
|
72222
|
72223
|
72224
|
77080
|
77081
|
77082
|
77083
|
77084
|
77085
|
77086
|
77087
|
77207
|
77208
|
77209
|
77210
|
77211
|
77212
|
77213
|
77214
|
77215
|
77218
|
77238
|
77649
|
77650
|
77651
|
77652
|
77653
|
77654
|
77655
|
77656
|
77657
|
77658
|
77659
|
78346
|
78347
|
78348
|
78349
|
78350
|
78351
|
78352
|
78353
|
78354
|
78355
|
78356
|
78674
|
78675
|
78676
|
78677
|
78678
|
78679
|
78680
|
78681
|
78682
|
78683
|
78684
|
78743
|
78744
|
78745
|
78746
|
78747
|
78748
|
78749
|
78750
|
78751
|
78752
|
78753
|
78879
|
79119
|
79626
|
79627
|
79628
|
79629
|
79630
|
79631
|
79632
|
79633
|
79634
|
79635
|
79636
|
79637
|
79638
|
79639
|
79640
|
79641
|
79761
|
79762
|
79763
|
79764
|
79765
|
79766
|
79767
|
79768
|
79769
|
79770
|
79771
|
79772
|
79773
|
79774
|
79775
|
79776
|
79778
|
79891