Bugzilla – Attachment 77297 Details for
Bug 20661
Implement blocking errors for circulation scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20661: (QA follow-up) Add POD for output_and_exit
Bug-20661-QA-follow-up-Add-POD-for-outputandexit.patch (text/plain), 1.30 KB, created by
Marcel de Rooy
on 2018-07-27 06:49:04 UTC
(
hide
)
Description:
Bug 20661: (QA follow-up) Add POD for output_and_exit
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-07-27 06:49:04 UTC
Size:
1.30 KB
patch
obsolete
>From 65928db4fbb6cf518f902bc86fc0cc9d1f19cfb7 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 27 Jul 2018 08:29:03 +0200 >Subject: [PATCH] Bug 20661: (QA follow-up) Add POD for output_and_exit >Content-Type: text/plain; charset=utf-8 > >Resolve: > FAIL C4/Output.pm > FAIL pod > *** ERROR: Apparent command =cut not preceded by blank line in file C4/Output.pm > FAIL pod coverage > POD is missing for output_and_exit > >Test plan: >Run QA tools again. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Output.pm | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > >diff --git a/C4/Output.pm b/C4/Output.pm >index eef4506..71f82e8 100644 >--- a/C4/Output.pm >+++ b/C4/Output.pm >@@ -62,7 +62,6 @@ C4::Output - Functions for managing output, is slowly being deprecated > =head1 FUNCTIONS > > =over 2 >-=cut > > =item pagination_bar > >@@ -342,6 +341,15 @@ sub output_and_exit_if_error { > return; > } > >+=item output_and_exit >+ >+ output_and_exit( $query, $cookie, $template, $error ); >+ >+ $error is a blocking error like biblionumber not found or so. >+ We should output the error and exit. >+ >+=cut >+ > sub output_and_exit { > my ( $query, $cookie, $template, $error ) = @_; > $template->param( blocking_error => $error ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20661
:
74858
|
75209
|
77296
| 77297