Bugzilla – Attachment 77299 Details for
Bug 21048
suggest_status not behaving properly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21048: (QA follow-up) Fix authorized value statuses in filter
Bug-21048-QA-follow-up-Fix-authorized-value-status.patch (text/plain), 1.79 KB, created by
Marcel de Rooy
on 2018-07-27 08:15:21 UTC
(
hide
)
Description:
Bug 21048: (QA follow-up) Fix authorized value statuses in filter
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-07-27 08:15:21 UTC
Size:
1.79 KB
patch
obsolete
>From edb003a45c84e143775493d6e6147d36236c904e Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 27 Jul 2018 09:42:06 +0200 >Subject: [PATCH] Bug 21048: (QA follow-up) Fix authorized value statuses in > filter >Content-Type: text/plain; charset=utf-8 > >If you select an authorized value status in the filter, you want to keep >it too just like normal statuses as CHECKED. >The variable selected_status was not filled. The minimal fix is adding that >template variable in the script. Note that suggestion.STATUS is out of scope >within a loop using suggestion as loop var. > >Note: Adding a regular status like CHECKED as an authorized value with >same code but another description works, but is kind of confusing ;) Not >in the scope of this report though. > >Test plan: >Select an authval status in the filter. Apply the filter and verify again >that it is still selected under Suggestion information. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > suggestion/suggestion.pl | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index 1604d62..845ed0e 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -353,7 +353,12 @@ foreach my $budget ( @{$budgets} ) { > } > > $template->param( budgetsloop => \@budgets_loop); >-$template->param( "statusselected_$$suggestion_ref{'STATUS'}" =>1) if ($$suggestion_ref{'STATUS'}); >+if( $suggestion_ref->{STATUS} ) { >+ $template->param( >+ "statusselected_".$suggestion_ref->{STATUS} => 1, >+ selected_status => $suggestion_ref->{STATUS}, # We need template var selected_status in the second part of the template where template var suggestion.STATUS is out of scope >+ ); >+} > > my @currencies = Koha::Acquisition::Currencies->search; > $template->param( >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21048
:
76744
|
76745
|
76746
|
76747
|
76872
|
76900
|
76925
|
77298
| 77299