From 9c7324a481fb54f8ed78eea783603099e33cbebe Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 16 Aug 2018 12:29:43 -0300 Subject: [PATCH] Bug 21238: Prevent TemplateToolkit.t to fail on slow servers It failed 3x in the last 6 runs (on node 1), we should mock DateTime->now to prevent it to fail again. The error is: koha_1 | # Failed test at t/db_dependent/Letters/TemplateToolkit.t line 724. When comparing <> replacement: koha_1 | # 08/16/2018 14:25
[...] koha_1 | # 08/16/2018 14:24
Let's mock DateTime->now to prevent it to fail again. Test plan: 0. Do not apply this patch 1. Add "sleep(60);" at line ~715, before "# Add a second checkout" 2. Run the tests => Fail! 3. Apply this patch 4. Run the tests again => Pass! Signed-off-by: Martin Renvoize --- t/db_dependent/Letters/TemplateToolkit.t | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Letters/TemplateToolkit.t b/t/db_dependent/Letters/TemplateToolkit.t index c4f4e82..2714317 100644 --- a/t/db_dependent/Letters/TemplateToolkit.t +++ b/t/db_dependent/Letters/TemplateToolkit.t @@ -20,6 +20,7 @@ use Modern::Perl; use Test::More tests => 18; +use Test::MockModule; use Test::Warn; use MARC::Record; @@ -56,7 +57,9 @@ $dbh->{RaiseError} = 1; $dbh->do(q|DELETE FROM letter|); -my $date = dt_from_string; +my $now_value = DateTime->now(); +my $mocked_datetime = Test::MockModule->new('DateTime'); +$mocked_datetime->mock( 'now', sub { return $now_value->clone; } ); my $library = $builder->build( { source => 'Branch' } ); my $patron = $builder->build( { source => 'Borrower' } ); -- 2.1.4