From 3cefc341b3ab686d8e9f37b57ee868d497659bd0 Mon Sep 17 00:00:00 2001 From: Nick Clemens <nick@bywatersolutions.com> Date: Fri, 17 Aug 2018 11:07:41 +0000 Subject: [PATCH] Bug 7996: Correct wrong permissions for modification log To test: 1 - Create a staff patron with catalogue,borrowers,and view_system_logs permissions 2 - Log in using that patron 3 - Go to tools 4 - Click 'Log viewer' 5 - You get a blank page 6 - View borrower circ screen, note you do not see 'Modification log' 7 - Edit a borrower, note you do not see 'Modification log' 8 - Apply patch 9 - 'Log Viewer' should now load correctly 10 - You should see 'Modification log' tab during circ 11 - You should see 'Modification log' tab when editing patron Signed-off-by: Owen Leonard <oleonard@myacpl.org> --- koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index 2d36462..950cc8e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -96,7 +96,7 @@ [% IF ( holdshistoryview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/holdshistory.pl?borrowernumber=[% patron.borrowernumber %]">Holds history</a></li> [% END %] [% END %] - [% IF ( CAN_user_parameters ) %] + [% IF ( CAN_user_tools_view_system_logs ) %] [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&object=[% patron.borrowernumber %]&src=circ">Modification log</a></li> [% END %] [% IF CAN_user_borrowers_edit_borrowers %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc index 43d0e5a..34d0812 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc @@ -9,7 +9,7 @@ [% IF ( intranetreadinghistory ) %] [% IF ( readingrecordview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/readingrec.pl?borrowernumber=[% borrowernumber %]">Circulation history</a></li> [% END %] - [% IF ( CAN_user_parameters ) %] + [% IF ( CAN_user_tools_view_system_logs ) %] [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&action=MODIFY&object=[% borrowernumber %]">Modification log</a></li> [% END %] [% IF ( sentnotices ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/members/notices.pl?borrowernumber=[% borrowernumber %]">Notices</a></li> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt index b183dca..a92b3d3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt @@ -80,7 +80,7 @@ <div id="bd"> <div id="yui-main"> <div class="yui-b"> - [% IF ( CAN_user_reports ) %] + [% IF ( CAN_user_tools_view_system_logs ) %] <h1>Browse system logs</h1> <form method="post" action="/cgi-bin/koha/tools/viewlog.pl"> [% IF ( do_it ) %] -- 2.1.4