Bugzilla – Attachment 78088 Details for
Bug 19383
Print hold slips without confirmation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19383: (QA follow-up) Remove unused name variable
Bug-19383-QA-follow-up-Remove-unused-name-variable.patch (text/plain), 1.38 KB, created by
Katrin Fischer
on 2018-08-22 18:51:34 UTC
(
hide
)
Description:
Bug 19383: (QA follow-up) Remove unused name variable
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-08-22 18:51:34 UTC
Size:
1.38 KB
patch
obsolete
>From 0373ec4499b7dc1f5260a73685849ac3974a6574 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Wed, 22 Aug 2018 20:49:52 +0200 >Subject: [PATCH] Bug 19383: (QA follow-up) Remove unused name variable > >--- > circ/returns.pl | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index 5ac8a13..a514be5 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -425,7 +425,6 @@ if ( $messages->{'ResFound'}) { > my ( $messages, $nextreservinfo ) = GetOtherReserves($reserve->{itemnumber}); > > my $patron = Koha::Patrons->find( $nextreservinfo ); >- my $name = $patron ? $patron->surname . ", " . $patron->title . " " . $patron->firstname : ''; > > $template->param( > hold_auto_filled => 1, >@@ -441,7 +440,6 @@ if ( $messages->{'ResFound'}) { > itemnumber => $item->itemnumber, > itembiblionumber => $biblio->biblionumber, > iteminfo => $biblio->author, >- name => $name, > diffbranch => 1, > ); > } >@@ -464,7 +462,6 @@ if ( $messages->{'ResFound'}) { > > # same params for Waiting or Reserved > $template->param( >- # FIXME The full patron object should be passed to the template > found => 1, > patron => $patron, > barcode => $barcode, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19383
:
75009
|
75015
|
76787
|
78087
| 78088