From 6551ebef61a07276313a655de705e95f2bd96043 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 16 Feb 2018 09:02:39 +0100 Subject: [PATCH] Bug 15524: (QA follow-up) Fix meaningless test The last test claims to allow a hold when branch=5 and patron=5, but look at the preceding statements: $rule_branch->max_holds(5); $rule_branch->update(); $rule_branch->max_holds(5); $rule_branch->insert(); The last insert will not be done, since the record is already present. A create should have triggered an error on the primary key. Obviously, we should use $rule_all. Test plan: Run the test again. Signed-off-by: Marcel de Rooy --- t/db_dependent/Holds.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t index b75b895..8f1eaf2 100755 --- a/t/db_dependent/Holds.t +++ b/t/db_dependent/Holds.t @@ -472,8 +472,8 @@ subtest 'Test max_holds per library/patron category' => sub { $rule_branch->max_holds(5); $rule_branch->update(); - $rule_branch->max_holds(5); - $rule_branch->insert(); + $rule_all->max_holds(5); + $rule_all->insert(); $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber ); is( $ret, 'OK', 'Patron can place hold with branch/category rule of 5, category rule of 5' ); -- 2.1.4