View | Details | Raw Unified | Return to bug 15524
Collapse All | Expand All

(-)a/C4/Circulation.pm (-1 / +1 lines)
Lines 1183-1189 sub checkHighHolds { Link Here
1183
            }
1183
            }
1184
1184
1185
            # Remove any items that are not holdable for this patron
1185
            # Remove any items that are not holdable for this patron
1186
            @items = grep { CanItemBeReserved( $borrower->{borrowernumber}, $_->itemnumber ) eq 'OK' } @items;
1186
            @items = grep { CanItemBeReserved( $borrower->{borrowernumber}, $_->itemnumber )->{status} eq 'OK' } @items;
1187
1187
1188
            my $items_count = scalar @items;
1188
            my $items_count = scalar @items;
1189
1189
(-)a/C4/Reserves.pm (-1 / +1 lines)
Lines 299-305 sub CanBookBeReserved{ Link Here
299
         { status => ageRestricted },   if the Item is age restricted for this borrower.
299
         { status => ageRestricted },   if the Item is age restricted for this borrower.
300
         { status => damaged },         if the Item is damaged.
300
         { status => damaged },         if the Item is damaged.
301
         { status => cannotReserveFromOtherBranches }, if syspref 'canreservefromotherbranches' is OK.
301
         { status => cannotReserveFromOtherBranches }, if syspref 'canreservefromotherbranches' is OK.
302
         { status => tooManyReserves, limit => $limit }, if the borrower has exceeded his maximum reserve amount.
302
         { status => tooManyReserves, limit => $limit }, if the borrower has exceeded their maximum reserve amount.
303
         { status => notReservable },   if holds on this item are not allowed
303
         { status => notReservable },   if holds on this item are not allowed
304
304
305
=cut
305
=cut
(-)a/Koha/REST/V1/Hold.pm (-1 / +1 lines)
Lines 91-97 sub add { Link Here
91
91
92
    unless ($can_reserve->{status} eq 'OK') {
92
    unless ($can_reserve->{status} eq 'OK') {
93
        return $c->render( status => 403, openapi => {
93
        return $c->render( status => 403, openapi => {
94
            error => "Reserve cannot be placed. Reason: $can_reserve"
94
            error => "Reserve cannot be placed. Reason: ". $can_reserve->{status}
95
        } );
95
        } );
96
    }
96
    }
97
97
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt (-1 / +1 lines)
Lines 515-521 Link Here
515
                        <td>[% IF ( branch_cat_rule_loo.unlimited_max_holds ) %]
515
                        <td>[% IF ( branch_cat_rule_loo.unlimited_max_holds ) %]
516
                                Unlimited
516
                                Unlimited
517
                            [% ELSE %]
517
                            [% ELSE %]
518
                                [% branch_cat_rule_loo.max_holds %]
518
                                [% branch_cat_rule_loo.max_holds | html %]
519
                            [% END %]
519
                            [% END %]
520
                        </td>
520
                        </td>
521
521
(-)a/reserve/request.pl (-3 / +2 lines)
Lines 471-477 foreach my $biblionumber (@biblionumbers) { Link Here
471
                       !$item->{cantreserve}
471
                       !$item->{cantreserve}
472
                    && !$exceeded_maxreserves
472
                    && !$exceeded_maxreserves
473
                    && IsAvailableForItemLevelRequest($item, $patron_unblessed)
473
                    && IsAvailableForItemLevelRequest($item, $patron_unblessed)
474
                    && $can_item_be_reserved eq 'OK'
474
                    && $can_item_be_reserved->{status} eq 'OK'
475
                  )
475
                  )
476
                {
476
                {
477
                    $item->{available} = 1;
477
                    $item->{available} = 1;
Lines 479-485 foreach my $biblionumber (@biblionumbers) { Link Here
479
479
480
                    push( @available_itemtypes, $item->{itype} );
480
                    push( @available_itemtypes, $item->{itype} );
481
                }
481
                }
482
                elsif ( $can_item_be_reserved eq 'tooManyReserves' && C4::Context->preference('AllowHoldPolicyOverride') ) {
482
                elsif ( $can_item_be_reserved->{status} eq 'tooManyReserves' && C4::Context->preference('AllowHoldPolicyOverride') ) {
483
                    # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules
483
                    # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules
484
                    $item->{override} = 1;
484
                    $item->{override} = 1;
485
                    $num_override++;
485
                    $num_override++;
486
- 

Return to bug 15524