Bugzilla – Attachment 78410 Details for
Bug 20809
Link patron image to patron image add/edit form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20809: (follow-up) Corrections to CSS and JS
Bug-20809-follow-up-Corrections-to-CSS-and-JS.patch (text/plain), 3.86 KB, created by
Owen Leonard
on 2018-09-04 14:12:59 UTC
(
hide
)
Description:
Bug 20809: (follow-up) Corrections to CSS and JS
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2018-09-04 14:12:59 UTC
Size:
3.86 KB
patch
obsolete
>From 82c80a5ce6b12d6cf9978cf991facf65d3ca6b51 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 14 Aug 2018 14:26:23 +0000 >Subject: [PATCH] Bug 20809: (follow-up) Corrections to CSS and JS > >This follow-up modifies JavaScript so that the confirmation dialog is >triggered when deleting a patron image from the modal window. > >The CSS is modified to improve the alignment of patron image and edit >button. >--- > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 5 +++-- > koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 6 +++--- > 2 files changed, 6 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 8b40e22..6af611b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -1693,15 +1693,16 @@ dd { > } > > .patronimage { >+ border: 1px solid #EEE; > display: block; > max-width: 160px; >+ margin: auto; > opacity: 1; > transition: .2s ease; > >- .empty { >+ &.empty { > background: transparent url( "../img/patron-blank.min.svg" ) center 5px no-repeat; > height: 125px; >- margin: .3em 0 .3em .3em; > padding: 0; > width: 80%; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index a88a98e..d4a9676 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -269,9 +269,9 @@ > [% END %] > <form method="post" id="picture-upload" style="display:none;" action="/cgi-bin/koha/tools/picture-upload.pl" enctype="multipart/form-data"> > [% IF ( patron.image ) %] >- <div class="hint">To update the image for [% patron.title | html %] [% patron.surname | html %], select a new image file and click 'Upload.' <br />Click the 'Delete' button to remove the current image.</div> >+ <div class="hint">To update the image for [% patron.title %] [% patron.firstname | html %] [% patron.surname | html %], select a new image file and click 'Upload.' <br />Click the 'Delete' button to remove the current image.</div> > [% ELSE %] >- <div class="hint">[% patron.title | html %] [% patron.firstname | html %] [% patron.surname | html %] does not currently have an image available. To import an image for [% patron.title | html %] [% patron.surname | html %], enter the name of an image file to upload.</div> >+ <div class="hint">[% patron.title | html %] [% patron.firstname | html %] [% patron.surname | html %] does not currently have an image available. To import an image for [% patron.title | html %] [% patron.firstname | html %] [% patron.surname | html %], enter the name of an image file to upload.</div> > [% END %] > <p>Only PNG, GIF, JPEG, XPM formats are supported.</p> > <label for="uploadfile">Select the file to upload: </label> >@@ -858,7 +858,7 @@ > "bPaginate": false > })); > [% IF ( patron.image ) %] >- $('#delpicture').click(function(){ >+ $("body").on("click", "#delpicture", function(){ > return confirm(_("Are you sure you want to delete this patron image? This cannot be undone.")); > }); > $('#manage-patron-image').find("input[value*=Upload]").click(function(){ >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20809
:
75514
|
75515
|
75637
|
75963
|
77462
|
77465
|
77789
|
77790
|
78409
|
78410
|
78595
|
78670
|
78711
|
82333
|
82334
|
82335
|
83711
|
83712
|
83713
|
83844
|
83845
|
83846
|
83847
|
84477
|
84478
|
84479
|
84480
|
84481
|
84482
|
84483
|
84484