From 4be52857bc06f80a162395db17da080c163d63cb Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Tue, 19 Apr 2016 12:15:46 +0200 Subject: [PATCH] Bug 15565: Set 'found' parameter correctly when ReservesNeedReturns is off MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Danielle Elder Signed-off-by: Séverine QUEUNE Signed-off-by: Kyle M Hall Signed-off-by: Benjamin Rokseth --- reserve/placerequest.pl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl index a07cdc6..2732ba9 100755 --- a/reserve/placerequest.pl +++ b/reserve/placerequest.pl @@ -71,13 +71,13 @@ foreach my $bibnum (@biblionumbers) { my @found; -foreach my $checkitem (@checkitems) { - # if we have an item selectionned, and the pickup branch is the same as the holdingbranch - # of the document, we force the value $rank and $found . - $rank[0] = '0' unless C4::Context->preference('ReservesNeedReturns'); - my $item = GetItem($checkitem); - if ( $item->{'holdingbranch'} eq $branch ){ - push @found, 'W' unless C4::Context->preference('ReservesNeedReturns'); +unless (C4::Context->preference('ReservesNeedReturns')) { + foreach my $checkitem (@checkitems) { + # if we have an item selectionned, and the pickup branch is the same as + # the holdingbranch of the document, we force the value $rank and $found + $rank[0] = 0; + my $item = GetItem($checkitem); + push @found, $item->{holdingbranch} eq $branch ? 'W' : undef; } } -- 2.1.4