Bugzilla – Attachment 78528 Details for
Bug 13779
sessionID declared twice in C4::Auth::checkauth()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl
Bug-13779-QA-follow-up-Correct-checkauth-call-in-o.patch (text/plain), 1.20 KB, created by
Marcel de Rooy
on 2018-09-07 15:03:02 UTC
(
hide
)
Description:
Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-09-07 15:03:02 UTC
Size:
1.20 KB
patch
obsolete
>From e95ef98dc4ed0b475f1763346df094d61094198d Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 7 Sep 2018 09:50:40 +0200 >Subject: [PATCH] Bug 13779: (QA follow-up) Correct checkauth call in > offline_circ/download.pl >Content-Type: text/plain; charset=utf-8 > >Script offline_circ/download.pl does not use the return values of >checkauth. So should not assign them to bad chosen variables that do >not correspond with checkauth but with get_template_and_user. > >Test plan: >Look for $template, $loggedinuser, $cookie, $flags in the code. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > offline_circ/download.pl | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/offline_circ/download.pl b/offline_circ/download.pl >index 713057c..2b6c67e 100755 >--- a/offline_circ/download.pl >+++ b/offline_circ/download.pl >@@ -27,8 +27,7 @@ use C4::Context; > use C4::Koha; > > my $query = new CGI; >-my ( $template, $loggedinuser, $cookie, $flags ) = >- checkauth( $query, undef, { circulate => "circulate_remaining_permissions" }, >+checkauth( $query, undef, { circulate => "circulate_remaining_permissions" }, > "intranet" ); > > my $page = $query->param('page') || 0; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13779
:
77099
|
78452
|
78527
| 78528