Bugzilla – Attachment 78833 Details for
Bug 21178
Add Koha::Patron::set_password method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21178: (QA follow-up) whitespace characters fix
Bug-21178-QA-follow-up-whitespace-characters-fix.patch (text/plain), 2.00 KB, created by
Tomás Cohen Arazi
on 2018-09-14 23:16:09 UTC
(
hide
)
Description:
Bug 21178: (QA follow-up) whitespace characters fix
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2018-09-14 23:16:09 UTC
Size:
2.00 KB
patch
obsolete
>From 01a8b2c5f3fb5d8a968fffdfb62422395e342903 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 14 Sep 2018 16:15:13 -0700 >Subject: [PATCH] Bug 21178: (QA follow-up) whitespace characters fix > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Patron.pm | 5 ++--- > t/db_dependent/Koha/Patrons.t | 3 +-- > 2 files changed, 3 insertions(+), 5 deletions(-) > >diff --git a/Koha/Patron.pm b/Koha/Patron.pm >index c26eda041a..f9214a6eed 100644 >--- a/Koha/Patron.pm >+++ b/Koha/Patron.pm >@@ -668,7 +668,7 @@ Exceptions are thrown if the password is not good enough. > > =item Koha::Exceptions::Password::TooShort > >-=item Koha::Exceptions::Password::TrailingWhitespaces >+=item Koha::Exceptions::Password::WhitespaceCharacters > > =item Koha::Exceptions::Password::TooWeak > >@@ -691,8 +691,7 @@ sub set_password { > { length => $password_length, min_length => $min_length } ); > } > elsif ( $error eq 'has_whitespaces' ) { >- Koha::Exceptions::Password::TrailingWhitespaces->throw( >- "Password contains trailing spaces, which is forbidden."); >+ Koha::Exceptions::Password::WhitespaceCharacters->throw(); > } > elsif ( $error eq 'too_weak' ) { > Koha::Exceptions::Password::TooWeak->throw(); >diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t >index f8c8a8046e..35fff0ff54 100644 >--- a/t/db_dependent/Koha/Patrons.t >+++ b/t/db_dependent/Koha/Patrons.t >@@ -1500,7 +1500,6 @@ subtest '->store' => sub { > $schema->storage->txn_rollback; > }; > >- > subtest '->set_password' => sub { > > plan tests => 11; >@@ -1530,7 +1529,7 @@ subtest '->set_password' => sub { > > # Trailing spaces tests > throws_ok { $patron->set_password('abcD12d '); } >- 'Koha::Exceptions::Password::TrailingWhitespaces', >+ 'Koha::Exceptions::Password::WhitespaceCharacters', > 'Password contains trailing spaces, exception is thrown'; > > # Require strong password tests >-- >2.19.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21178
:
77575
|
77576
|
77577
|
77578
|
77632
|
77885
|
77886
|
77916
|
77917
|
78833
|
80133
|
80134
|
80135
|
80136