View | Details | Raw Unified | Return to bug 15516
Collapse All | Expand All

(-)a/C4/Reserves.pm (-32 / +32 lines)
Lines 139-147 BEGIN { Link Here
139
139
140
        GetMaxPatronHoldsForRecord
140
        GetMaxPatronHoldsForRecord
141
141
142
        &AddReserveGroup
142
        &AddHoldGroup
143
        &DeleteReserveGroup
143
        &DeleteHoldGroup
144
        &GetReserveGroupReserves
144
        &GetHoldGroupHolds
145
    );
145
    );
146
    @EXPORT_OK = qw( MergeHolds );
146
    @EXPORT_OK = qw( MergeHolds );
147
}
147
}
Lines 168-174 sub AddReserve { Link Here
168
        $branch,   $borrowernumber, $biblionumber, $bibitems,
168
        $branch,   $borrowernumber, $biblionumber, $bibitems,
169
        $priority, $resdate,        $expdate,      $notes,
169
        $priority, $resdate,        $expdate,      $notes,
170
        $title,    $checkitem,      $found,        $itemtype,
170
        $title,    $checkitem,      $found,        $itemtype,
171
        $reserve_group_id
171
        $hold_group_id
172
    ) = @_;
172
    ) = @_;
173
173
174
    $resdate = output_pref( { str => dt_from_string( $resdate ), dateonly => 1, dateformat => 'iso' })
174
    $resdate = output_pref( { str => dt_from_string( $resdate ), dateonly => 1, dateformat => 'iso' })
Lines 216-222 sub AddReserve { Link Here
216
            waitingdate    => $waitingdate,
216
            waitingdate    => $waitingdate,
217
            expirationdate => $expdate,
217
            expirationdate => $expdate,
218
            itemtype       => $itemtype,
218
            itemtype       => $itemtype,
219
            reserve_group_id => $reserve_group_id,
219
            hold_group_id => $hold_group_id,
220
        }
220
        }
221
    )->store();
221
    )->store();
222
    $hold->set_waiting() if $found eq 'W';
222
    $hold->set_waiting() if $found eq 'W';
Lines 523-529 sub GetReserveCount { Link Here
523
        SELECT COUNT(*) AS counter
523
        SELECT COUNT(*) AS counter
524
        FROM reserves
524
        FROM reserves
525
        WHERE borrowernumber = ?
525
        WHERE borrowernumber = ?
526
        AND reserve_group_id is NULL"; #added by 15516
526
        AND hold_group_id is NULL"; #added by 15516
527
    my $sth = $dbh->prepare($query);
527
    my $sth = $dbh->prepare($query);
528
    $sth->execute($borrowernumber);
528
    $sth->execute($borrowernumber);
529
    my $row = $sth->fetchrow_hashref;
529
    my $row = $sth->fetchrow_hashref;
Lines 532-541 sub GetReserveCount { Link Here
532
    $count += $row->{counter};
532
    $count += $row->{counter};
533
533
534
    $query = "
534
    $query = "
535
        SELECT COUNT(DISTINCT reserve_group_id) AS counter
535
        SELECT COUNT(DISTINCT hold_group_id) AS counter
536
        FROM reserves
536
        FROM reserves
537
        WHERE borrowernumber = ?
537
        WHERE borrowernumber = ?
538
        AND reserve_group_id is not NULL
538
        AND hold_group_id is not NULL
539
    ";
539
    ";
540
    $sth = $dbh->prepare($query);
540
    $sth = $dbh->prepare($query);
541
    $sth->execute($borrowernumber);
541
    $sth->execute($borrowernumber);
Lines 1103-1116 sub ModReserveAffect { Link Here
1103
    $hold->itemnumber($itemnumber);
1103
    $hold->itemnumber($itemnumber);
1104
    $hold->set_waiting($transferToDo);
1104
    $hold->set_waiting($transferToDo);
1105
1105
1106
    if ($hold->reserve_group_id) {
1106
    if ($hold->hold_group_id) {
1107
        # Delete other reserves from same group
1107
        # Delete other reserves from same group
1108
        $dbh->do(q{
1108
        $dbh->do(q{
1109
            DELETE FROM reserves
1109
            DELETE FROM reserves
1110
            WHERE reserve_group_id = ?
1110
            WHERE hold_group_id = ?
1111
              AND reserve_id != ?
1111
              AND reserve_id != ?
1112
        }, undef, $hold->reserve_group_id, $hold->reserve_id);
1112
        }, undef, $hold->hold_group_id, $hold->reserve_id);
1113
        DeleteReserveGroup($hold->reserve_group_id);
1113
        DeleteHoldGroup($hold->hold_group_id);
1114
    }
1114
    }
1115
1115
1116
    _koha_notify_reserve( $hold->reserve_id )
1116
    _koha_notify_reserve( $hold->reserve_id )
Lines 2199-2252 sub GetHoldRule { Link Here
2199
    return $sth->fetchrow_hashref();
2199
    return $sth->fetchrow_hashref();
2200
}
2200
}
2201
2201
2202
=head2 AddReserveGroup
2202
=head2 AddHoldGroup
2203
2203
2204
    my $reserve_group_id = AddReserveGroup();
2204
    my $hold_group_id = AddHoldGroup();
2205
2205
2206
Creates a new reserve group and returns its ID
2206
Creates a new hold group and returns its ID
2207
2207
2208
=cut
2208
=cut
2209
2209
2210
sub AddReserveGroup {
2210
sub AddHoldGroup {
2211
    my $dbh = C4::Context->dbh;
2211
    my $dbh = C4::Context->dbh;
2212
2212
2213
    $dbh->do('INSERT INTO reserve_group VALUES ()');
2213
    $dbh->do('INSERT INTO hold_group VALUES ()');
2214
    return $dbh->last_insert_id(undef, undef, 'reserve_group', undef);
2214
    return $dbh->last_insert_id(undef, undef, 'hold_group', undef);
2215
}
2215
}
2216
2216
2217
=head2 DeleteReserveGroup
2217
=head2 DeleteHoldGroup
2218
2218
2219
    DeleteReserveGroup($reserve_group_id);
2219
    DeleteHoldGroup($hold_group_id);
2220
2220
2221
Delete a reserve group. Reserves that belong to this group are not removed.
2221
Delete a hold group. Reserves that belong to this group are not removed.
2222
2222
2223
=cut
2223
=cut
2224
2224
2225
sub DeleteReserveGroup {
2225
sub DeleteHoldGroup {
2226
    my ($reserve_group_id) = @_;
2226
    my ($hold_group_id) = @_;
2227
2227
2228
    my $dbh = C4::Context->dbh;
2228
    my $dbh = C4::Context->dbh;
2229
    my $query = 'DELETE FROM reserve_group WHERE reserve_group_id = ?';
2229
    my $query = 'DELETE FROM hold_group WHERE hold_group_id = ?';
2230
    $dbh->do($query, undef, $reserve_group_id);
2230
    $dbh->do($query, undef, $hold_group_id);
2231
}
2231
}
2232
2232
2233
=head2 GetReserveGroupReserves
2233
=head2 GetHoldGroupHolds
2234
2234
2235
    my @reserves = GetReserveGroupReserves($reserve_group_id);
2235
    my @reserves = GetHoldGroupHolds($hold_group_id);
2236
2236
2237
Fetch all reserve from a reserve group.
2237
Fetch all reserve from a hold group.
2238
2238
2239
=cut
2239
=cut
2240
2240
2241
sub GetReserveGroupReserves {
2241
sub GetHoldGroupHolds {
2242
    my ($reserve_group_id) = @_;
2242
    my ($hold_group_id) = @_;
2243
2243
2244
    my $dbh = C4::Context->dbh;
2244
    my $dbh = C4::Context->dbh;
2245
2245
2246
    my $reserves = $dbh->selectall_arrayref(q{
2246
    my $reserves = $dbh->selectall_arrayref(q{
2247
        SELECT * FROM reserves
2247
        SELECT * FROM reserves
2248
        WHERE reserve_group_id = ?
2248
        WHERE hold_group_id = ?
2249
    }, { Slice => {} }, $reserve_group_id);
2249
    }, { Slice => {} }, $hold_group_id);
2250
2250
2251
    return () unless defined $reserves;
2251
    return () unless defined $reserves;
2252
2252
(-)a/installer/data/mysql/atomicupdate/bug_15516.sql (-8 / +8 lines)
Lines 1-11 Link Here
1
DROP TABLE IF EXISTS reserve_group;
1
DROP TABLE IF EXISTS hold_group;
2
CREATE TABLE reserve_group (
2
CREATE TABLE hold_group (
3
  reserve_group_id int unsigned NOT NULL AUTO_INCREMENT,
3
  hold_group_id int unsigned NOT NULL AUTO_INCREMENT,
4
  PRIMARY KEY (reserve_group_id)
4
  PRIMARY KEY (hold_group_id)
5
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
5
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
6
6
7
ALTER TABLE reserves ADD COLUMN reserve_group_id int unsigned NULL DEFAULT NULL;
7
ALTER TABLE reserves ADD COLUMN hold_group_id int unsigned NULL DEFAULT NULL;
8
ALTER TABLE reserves ADD CONSTRAINT reserves_ibfk_6 FOREIGN KEY (reserve_group_id) REFERENCES reserve_group (reserve_group_id) ON DELETE SET NULL ON UPDATE CASCADE;
8
ALTER TABLE reserves ADD CONSTRAINT reserves_ibfk_6 FOREIGN KEY (hold_group_id) REFERENCES hold_group (hold_group_id) ON DELETE SET NULL ON UPDATE CASCADE;
9
9
10
ALTER TABLE old_reserves ADD COLUMN reserve_group_id int unsigned NULL DEFAULT NULL;
10
ALTER TABLE old_reserves ADD COLUMN hold_group_id int unsigned NULL DEFAULT NULL;
11
ALTER TABLE old_reserves ADD CONSTRAINT old_reserves_ibfk_5 FOREIGN KEY (reserve_group_id) REFERENCES reserve_group (reserve_group_id) ON DELETE SET NULL ON UPDATE CASCADE;
11
ALTER TABLE old_reserves ADD CONSTRAINT old_reserves_ibfk_5 FOREIGN KEY (hold_group_id) REFERENCES hold_group (hold_group_id) ON DELETE SET NULL ON UPDATE CASCADE;
(-)a/installer/data/mysql/kohastructure.sql (-9 / +9 lines)
Lines 1781-1787 CREATE TABLE `old_issues` ( -- lists items that were checked out and have been r Link Here
1781
    ON DELETE SET NULL ON UPDATE SET NULL,
1781
    ON DELETE SET NULL ON UPDATE SET NULL,
1782
  CONSTRAINT `old_issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`)
1782
  CONSTRAINT `old_issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`)
1783
    ON DELETE SET NULL ON UPDATE SET NULL,
1783
    ON DELETE SET NULL ON UPDATE SET NULL,
1784
  CONSTRAINT `old_reserves_ibfk_5` FOREIGN KEY (reserve_group_id) REFERENCES reserve_group (reserve_group_id)
1784
  CONSTRAINT `old_reserves_ibfk_5` FOREIGN KEY (hold_group_id) REFERENCES hold_group (hold_group_id)
1785
    ON DELETE SET NULL ON UPDATE CASCADE
1785
    ON DELETE SET NULL ON UPDATE CASCADE
1786
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1786
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1787
1787
Lines 1884-1890 CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha Link Here
1884
  `suspend` BOOLEAN NOT NULL DEFAULT 0,
1884
  `suspend` BOOLEAN NOT NULL DEFAULT 0,
1885
  `suspend_until` DATETIME NULL DEFAULT NULL,
1885
  `suspend_until` DATETIME NULL DEFAULT NULL,
1886
  `itemtype` VARCHAR(10) NULL DEFAULT NULL, -- If record level hold, the optional itemtype of the item the patron is requesting
1886
  `itemtype` VARCHAR(10) NULL DEFAULT NULL, -- If record level hold, the optional itemtype of the item the patron is requesting
1887
  `reserve_group_id` int unsigned NULL DEFAULT NULL,  -- Id used on reservations spanning multiple titles
1887
  `hold_group_id` int unsigned NULL DEFAULT NULL,  -- Id used on reservations spanning multiple titles
1888
  PRIMARY KEY (`reserve_id`),
1888
  PRIMARY KEY (`reserve_id`),
1889
  KEY priorityfoundidx (priority,found),
1889
  KEY priorityfoundidx (priority,found),
1890
  KEY `borrowernumber` (`borrowernumber`),
1890
  KEY `borrowernumber` (`borrowernumber`),
Lines 1897-1913 CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha Link Here
1897
  CONSTRAINT `reserves_ibfk_3` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE,
1897
  CONSTRAINT `reserves_ibfk_3` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE,
1898
  CONSTRAINT `reserves_ibfk_4` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE,
1898
  CONSTRAINT `reserves_ibfk_4` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE,
1899
  CONSTRAINT `reserves_ibfk_5` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE,
1899
  CONSTRAINT `reserves_ibfk_5` FOREIGN KEY (`itemtype`) REFERENCES `itemtypes` (`itemtype`) ON DELETE CASCADE ON UPDATE CASCADE,
1900
  CONSTRAINT `reserves_ibfk_6` FOREIGN KEY (`reserve_group_id`) REFERENCES `reserve_group` (`reserve_group_id`) ON DELETE SET NULL ON UPDATE CASCADE
1900
  CONSTRAINT `reserves_ibfk_6` FOREIGN KEY (`hold_group_id`) REFERENCES `hold_group` (`hold_group_id`) ON DELETE SET NULL ON UPDATE CASCADE
1901
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1901
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1902
1902
1903
--
1903
--
1904
-- Table structure for table reserve_group
1904
-- Table structure for table hold_group
1905
--
1905
--
1906
1906
1907
DROP TABLE IF EXISTS `reserve_group`;
1907
DROP TABLE IF EXISTS `hold_group`;
1908
CREATE TABLE `reserve_group` (
1908
CREATE TABLE `hold_group` (
1909
  `reserve_group_id` int unsigned NOT NULL AUTO_INCREMENT,
1909
  `hold_group_id` int unsigned NOT NULL AUTO_INCREMENT,
1910
  PRIMARY KEY(`reserve_group_id`)
1910
  PRIMARY KEY(`hold_group_id`)
1911
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1911
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;
1912
1912
1913
--
1913
--
Lines 1935-1941 CREATE TABLE `old_reserves` ( -- this table holds all holds/reserves that have b Link Here
1935
  `suspend` BOOLEAN NOT NULL DEFAULT 0, -- in this hold suspended (1 for yes, 0 for no)
1935
  `suspend` BOOLEAN NOT NULL DEFAULT 0, -- in this hold suspended (1 for yes, 0 for no)
1936
  `suspend_until` DATETIME NULL DEFAULT NULL, -- the date this hold is suspended until (NULL for infinitely)
1936
  `suspend_until` DATETIME NULL DEFAULT NULL, -- the date this hold is suspended until (NULL for infinitely)
1937
  `itemtype` VARCHAR(10) NULL DEFAULT NULL, -- If record level hold, the optional itemtype of the item the patron is requesting
1937
  `itemtype` VARCHAR(10) NULL DEFAULT NULL, -- If record level hold, the optional itemtype of the item the patron is requesting
1938
  `reserve_group_id` int unsigned NULL DEFAULT NULL,  -- The id of a group of titles reservations fulfilled when one title is picked
1938
  `hold_group_id` int unsigned NULL DEFAULT NULL,  -- The id of a group of titles reservations fulfilled when one title is picked
1939
  PRIMARY KEY (`reserve_id`),
1939
  PRIMARY KEY (`reserve_id`),
1940
  KEY `old_reserves_borrowernumber` (`borrowernumber`),
1940
  KEY `old_reserves_borrowernumber` (`borrowernumber`),
1941
  KEY `old_reserves_biblionumber` (`biblionumber`),
1941
  KEY `old_reserves_biblionumber` (`biblionumber`),
(-)a/koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc (+27 lines)
Line 0 Link Here
1
<div id="hold-group-modal" class="modal hide" tabindex="-1" role="dialog" aria-labelledby="hold-group-modal-label" aria-hidden="true">
2
    <div class="modal-header">
3
        <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">×</button>
4
        <h3 id="hold-group-modal-label">Reserve group</h3>
5
    </div>
6
    <div class="modal-body">
7
        <div id="loading"> <img src="[% interface %]/[% theme %]/img/loading-small.gif" alt="" /> Loading </div>
8
    </div>
9
    <div class="modal-footer">
10
        <button class="btn" data-dismiss="modal" aria-hidden="true">Close</button>
11
    </div>
12
</div>
13
14
<script>
15
  $(document).ready(function() {
16
    $('body').on('click', 'a.hold-group', function() {
17
      var href = $(this).attr('href');
18
      $('#hold-group-modal .modal-body').load(href + " #main");
19
      $('#hold-group-modal').modal('show');
20
      return false;
21
    })
22
23
    $('#hold-group-modal').on('hidden', function(){
24
        $('#hold-group-modal .modal-body').html('<div id="loading"><img src="[% interface %]/[% theme %]/img/loading-small.gif" alt="" /> ' + _('Loading') + '</div>');
25
    });
26
  });
27
</script>
(-)a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc (-2 / +2 lines)
Lines 154-161 Link Here
154
                        <input type="hidden" name="itemnumber" value="" />
154
                        <input type="hidden" name="itemnumber" value="" />
155
                    [% END %]
155
                    [% END %]
156
                [% END %]
156
                [% END %]
157
                [% IF hold.reserve_group_id %]
157
                [% IF hold.hold_group_id %]
158
                    <div>(part of a <a href="/cgi-bin/koha/reserve/reserve-group.pl?reserve_group_id=[% hold.reserve_group_id %]" class="reserve-group">reserve group</a>)</div>
158
                    <div>(part of a <a href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[% hold.hold_group_id %]" class="hold-group">hold group</a>)</div>
159
                [% END %]
159
                [% END %]
160
            </td>
160
            </td>
161
161
(-)a/koha-tmpl/intranet-tmpl/prog/en/includes/reserve-group-modal.inc (-27 lines)
Lines 1-27 Link Here
1
<div id="reserve-group-modal" class="modal hide" tabindex="-1" role="dialog" aria-labelledby="reserve-group-modal-label" aria-hidden="true">
2
    <div class="modal-header">
3
        <button type="button" class="closebtn" data-dismiss="modal" aria-hidden="true">×</button>
4
        <h3 id="reserve-group-modal-label">Reserve group</h3>
5
    </div>
6
    <div class="modal-body">
7
        <div id="loading"> <img src="[% interface %]/[% theme %]/img/loading-small.gif" alt="" /> Loading </div>
8
    </div>
9
    <div class="modal-footer">
10
        <button class="btn" data-dismiss="modal" aria-hidden="true">Close</button>
11
    </div>
12
</div>
13
14
<script>
15
  $(document).ready(function() {
16
    $('body').on('click', 'a.reserve-group', function() {
17
      var href = $(this).attr('href');
18
      $('#reserve-group-modal .modal-body').load(href + " #main");
19
      $('#reserve-group-modal').modal('show');
20
      return false;
21
    })
22
23
    $('#reserve-group-modal').on('hidden', function(){
24
        $('#reserve-group-modal .modal-body').html('<div id="loading"><img src="[% interface %]/[% theme %]/img/loading-small.gif" alt="" /> ' + _('Loading') + '</div>');
25
    });
26
  });
27
</script>
(-)a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc (-1 / +1 lines)
Lines 47-52 Link Here
47
    var MSG_NO_ITEMTYPE = _("No itemtype");
47
    var MSG_NO_ITEMTYPE = _("No itemtype");
48
    var MSG_CHECKOUTS_BY_ITEMTYPE = _("Number of checkouts by item type");
48
    var MSG_CHECKOUTS_BY_ITEMTYPE = _("Number of checkouts by item type");
49
    var PART_OF_A = _("(part of a %s)");
49
    var PART_OF_A = _("(part of a %s)");
50
    var RESERVE_GROUP = _("reserve group");
50
    var HOLD_GROUP = _("hold group");
51
//]]>
51
//]]>
52
</script>
52
</script>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt (-3 / +3 lines)
Lines 80-87 Link Here
80
                [% INCLUDE 'biblio-default-view.inc' biblionumber = reserveloo.biblionumber %]
80
                [% INCLUDE 'biblio-default-view.inc' biblionumber = reserveloo.biblionumber %]
81
                [% reserveloo.title | html %] [% FOREACH s IN reserveloo.subtitle %] [% s | html %][% END %]</a></p>
81
                [% reserveloo.title | html %] [% FOREACH s IN reserveloo.subtitle %] [% s | html %][% END %]</a></p>
82
                [% IF ( reserveloo.author ) %]<p> by [% reserveloo.author | html %]</p>[% END %]
82
                [% IF ( reserveloo.author ) %]<p> by [% reserveloo.author | html %]</p>[% END %]
83
                [% IF reserveloo.reserve_group_id %]
83
                [% IF reserveloo.hold_group_id %]
84
                    <p>(part of a <a class="reserve-group" href="/cgi-bin/koha/reserve/reserve-group.pl?reserve_group_id=[% reserveloo.reserve_group_id | html %]">reserve group</a>)</p>
84
                    <p>(part of a <a class="hold-group" href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=[% reserveloo.hold_group_id | html %]">hold group</a>)</p>
85
                [% END %]
85
                [% END %]
86
            </td>
86
            </td>
87
        [% ELSE %]
87
        [% ELSE %]
Lines 266-270 Link Here
266
[% END %]
266
[% END %]
267
267
268
[%# TODO: this module needs to be separated to html and js part to be included correctly %]
268
[%# TODO: this module needs to be separated to html and js part to be included correctly %]
269
[% INCLUDE 'reserve-group-modal.inc' %]
269
[% INCLUDE 'hold-group-modal.inc' %]
270
[% INCLUDE 'intranet-bottom.inc' %]
270
[% INCLUDE 'intranet-bottom.inc' %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt (-1 / +1 lines)
Lines 929-933 Link Here
929
    </script>
929
    </script>
930
[% END %]
930
[% END %]
931
931
932
[% INCLUDE 'reserve-group-modal.inc' %]
932
[% INCLUDE 'hold-group-modal.inc' %]
933
[% INCLUDE 'intranet-bottom.inc' %]
933
[% INCLUDE 'intranet-bottom.inc' %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/reserve-group.tt (-9 / +9 lines)
Lines 1-12 Link Here
1
[% USE Biblio %]
1
[% USE Biblio %]
2
[% INCLUDE 'doc-head-open.inc' %]
2
[% INCLUDE 'doc-head-open.inc' %]
3
  <title>Koha &rsaquo; Circulation &rsaquo; Holds &rsaquo; Holds group ([% reserve_group_id %])</title>
3
  <title>Koha &rsaquo; Circulation &rsaquo; Holds &rsaquo; Holds group ([% hold_group_id %])</title>
4
  [% INCLUDE 'doc-head-close.inc' %]
4
  [% INCLUDE 'doc-head-close.inc' %]
5
</head>
5
</head>
6
<body id="reserve-reserve-group">
6
<body id="hold.hold-group">
7
  <h1>Holds group ([% reserve_group_id %])</h1>
7
  <h1>Holds group ([% hold_group_id %])</h1>
8
  <div id="main">
8
  <div id="main">
9
    [% IF reserves.size %]
9
    [% IF holds.size %]
10
      <table>
10
      <table>
11
        <thead>
11
        <thead>
12
          <tr>
12
          <tr>
Lines 16-27 Link Here
16
          </tr>
16
          </tr>
17
        </thead>
17
        </thead>
18
        <tbody>
18
        <tbody>
19
          [% FOREACH reserve IN reserves %]
19
          [% FOREACH hold IN holds %]
20
            [% biblio = Biblio.Get(reserve.biblionumber) %]
20
            [% biblio = Biblio.Get(hold.biblionumber) %]
21
            <tr>
21
            <tr>
22
              <td><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio.biblionumber %]">[% biblio.title %]</a></td>
22
              <td><a href="/cgi-bin/koha/hold.request.pl?biblionumber=[% biblio.biblionumber %]">[% biblio.title %]</a></td>
23
              <td>[% reserve.priority %]</td>
23
              <td>[% hold.priority %]</td>
24
              <td>[% reserve.reservenotes %]</td>
24
              <td>[% hold.reservenotes %]</td>
25
            </tr>
25
            </tr>
26
          [% END %]
26
          [% END %]
27
        </tbody>
27
        </tbody>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt (-1 / +1 lines)
Lines 865-870 Link Here
865
    </script>
865
    </script>
866
[% END %]
866
[% END %]
867
867
868
[% INCLUDE 'reserve-group-modal.inc' %]
868
[% INCLUDE 'hold-group-modal.inc' %]
869
869
870
[% INCLUDE 'intranet-bottom.inc' %]
870
[% INCLUDE 'intranet-bottom.inc' %]
(-)a/koha-tmpl/intranet-tmpl/prog/js/holds.js (-2 / +2 lines)
Lines 42-50 $(document).ready(function() { Link Here
42
                                title += " - <span class='" + span_class + "'>" + oObj.itemnotes.escapeHtml() + "</span>"
42
                                title += " - <span class='" + span_class + "'>" + oObj.itemnotes.escapeHtml() + "</span>"
43
                            }
43
                            }
44
44
45
                            if (oObj.reserve_group_id) {
45
                            if (oObj.hold_group_id) {
46
                              title += '<br>';
46
                              title += '<br>';
47
                              var link = '<a class="reserve-group" href="/cgi-bin/koha/reserve/reserve-group.pl?reserve_group_id=' + oObj.reserve_group_id + '">' + RESERVE_GROUP +'</a>'
47
                              var link = '<a class="hold-group" href="/cgi-bin/koha/reserve/hold-group.pl?hold_group_id=' + oObj.hold_group_id + '">' + HOLD_GROUP +'</a>'
48
                              title += '<span>' + PART_OF_A.format(link) + '</span>';
48
                              title += '<span>' + PART_OF_A.format(link) + '</span>';
49
                            }
49
                            }
50
50
(-)a/reserve/reserve-group.pl (-5 / +5 lines)
Lines 24-42 use C4::Reserves; Link Here
24
24
25
my $cgi = new CGI;
25
my $cgi = new CGI;
26
my ($template, $loggedinuser, $cookie) = get_template_and_user({
26
my ($template, $loggedinuser, $cookie) = get_template_and_user({
27
    template_name   => "reserve/reserve-group.tt",
27
    template_name   => "reserve/hold-group.tt",
28
    query           => $cgi,
28
    query           => $cgi,
29
    type            => "intranet",
29
    type            => "intranet",
30
    authnotrequired => 0,
30
    authnotrequired => 0,
31
    flagsrequired   => { circulate => 'circulate_remaining_permissions' },
31
    flagsrequired   => { circulate => 'circulate_remaining_permissions' },
32
});
32
});
33
33
34
my $reserve_group_id = $cgi->param('reserve_group_id');
34
my $hold_group_id = $cgi->param('hold_group_id');
35
my @reserves = GetReserveGroupReserves($reserve_group_id);
35
my @reserves = GetHoldGroupHolds($hold_group_id);
36
36
37
$template->param(
37
$template->param(
38
    reserve_group_id => $reserve_group_id,
38
    hold_group_id => $hold_group_id,
39
    reserves => \@reserves,
39
    holds => \@holds,
40
);
40
);
41
41
42
output_html_with_http_headers $cgi, $cookie, $template->output;
42
output_html_with_http_headers $cgi, $cookie, $template->output;
(-)a/reserve/placerequest.pl (-3 / +3 lines)
Lines 73-81 my $found; Link Here
73
73
74
if ( $type eq 'str8' && $borrower ) {
74
if ( $type eq 'str8' && $borrower ) {
75
75
76
    my $reserve_group_id;
76
    my $hold_group_id;
77
    if ($multi_hold && $requestany) {
77
    if ($multi_hold && $requestany) {
78
        $reserve_group_id = AddReserveGroup();
78
        $hold_group_id = AddReserveGroup();
79
    }
79
    }
80
80
81
    foreach my $biblionumber ( keys %bibinfos ) {
81
    foreach my $biblionumber ( keys %bibinfos ) {
Lines 104-110 if ( $type eq 'str8' && $borrower ) { Link Here
104
            AddReserve($branch, $borrower->{'borrowernumber'}, $biblionumber,
104
            AddReserve($branch, $borrower->{'borrowernumber'}, $biblionumber,
105
                [$biblionumber], $bibinfo->{rank}, $startdate, $expirationdate,
105
                [$biblionumber], $bibinfo->{rank}, $startdate, $expirationdate,
106
                $notes, $bibinfo->{title}, $checkitem, $found, $itemtype,
106
                $notes, $bibinfo->{title}, $checkitem, $found, $itemtype,
107
                $reserve_group_id);
107
                $hold_group_id);
108
        } else {
108
        } else {
109
            # place a request on 1st available
109
            # place a request on 1st available
110
            for ( my $i = 0 ; $i < $holds_to_place_count ; $i++ ) {
110
            for ( my $i = 0 ; $i < $holds_to_place_count ; $i++ ) {
(-)a/svc/holds (-1 / +1 lines)
Lines 102-108 while ( my $h = $holds_rs->next() ) { Link Here
102
        waiting_here   => $h->branch()->branchcode() eq $branch,
102
        waiting_here   => $h->branch()->branchcode() eq $branch,
103
        priority       => $h->priority(),
103
        priority       => $h->priority(),
104
        itemtype_limit => $itemtype_limit,
104
        itemtype_limit => $itemtype_limit,
105
        reserve_group_id => $h->reserve_group_id,
105
        hold_group_id => $h->hold_group_id,
106
        subtitle       => GetRecordValue(
106
        subtitle       => GetRecordValue(
107
            'subtitle',
107
            'subtitle',
108
            GetMarcBiblio({ biblionumber => $biblionumber }),
108
            GetMarcBiblio({ biblionumber => $biblionumber }),
(-)a/t/db_dependent/Reserves/ReserveCount.t (-12 / +11 lines)
Lines 50-56 my $biblio = $builder->build( { source => 'Biblio', } ); Link Here
50
my $biblionumber = $biblio->{biblionumber};
50
my $biblionumber = $biblio->{biblionumber};
51
51
52
# Use AddReserve instead of TestBuilder because i don't manage
52
# Use AddReserve instead of TestBuilder because i don't manage
53
# to make TestBuilder set reserve_group_id to null. Idea ?
53
# to make TestBuilder set hold_group_id to null. Idea ?
54
my $reserve_id = AddReserve($branchcode, $borrowernumber,
54
my $reserve_id = AddReserve($branchcode, $borrowernumber,
55
$biblionumber, $biblionumber, 1, undef, undef, undef
55
$biblionumber, $biblionumber, 1, undef, undef, undef
56
$biblio->{title}, undef, undef, undef);
56
$biblio->{title}, undef, undef, undef);
Lines 58-66 $biblio->{title}, undef, undef, undef); Link Here
58
is(GetReserveCount($borrowernumber), 1, 'Test borrower has 1 reserve.');
58
is(GetReserveCount($borrowernumber), 1, 'Test borrower has 1 reserve.');
59
59
60
my $reserves_group = $builder->build({
60
my $reserves_group = $builder->build({
61
    source => 'ReserveGroup',
61
    source => 'HoldGroup',
62
    value => {
62
    value => {
63
        reserve_group_id => 1
63
        hold_group_id => 1
64
    }
64
    }
65
});
65
});
66
66
Lines 68-113 my $reserve2 = $builder->build({ Link Here
68
    source => 'Reserve',
68
    source => 'Reserve',
69
    value => {
69
    value => {
70
        borrowernumber => $borrowernumber,
70
        borrowernumber => $borrowernumber,
71
        reserve_group_id => 1
71
        hold_group_id => 1
72
    }
72
    }
73
});
73
});
74
my $reserve3 = $builder->build({
74
my $reserve3 = $builder->build({
75
    source => 'Reserve',
75
    source => 'Reserve',
76
    value => {
76
    value => {
77
        borrowernumber => $borrowernumber,
77
        borrowernumber => $borrowernumber,
78
        reserve_group_id => 1
78
        hold_group_id => 1
79
    }
79
    }
80
});
80
});
81
81
82
is(GetReserveCount($borrowernumber), 2, 'Test borrower has 2 reserve.');
82
is(GetReserveCount($borrowernumber), 2, 'Test borrower has 2 reserve.');
83
83
84
my $reserves_group2 = $builder->build({
84
my $reserves_group2 = $builder->build({
85
    source => 'ReserveGroup',
85
    source => 'HoldGroup',
86
    value => {
86
    value => {
87
        reserve_group_id => 2
87
        hold_group_id => 2
88
    }
88
    }
89
});
89
});
90
my $reserve_group_id2 = $reserves_group2->{reserve_group_id};
90
my $hold_group_id2 = $reserves_group2->{hold_group_id};
91
91
92
my $reserve4 = $builder->build({
92
my $reserve4 = $builder->build({
93
    source => 'Reserve',
93
    source => 'Reserve',
94
    value => {
94
    value => {
95
        borrowernumber => $borrowernumber,
95
        borrowernumber => $borrowernumber,
96
        reserve_group_id => 2
96
        hold_group_id => 2
97
    }
97
    }
98
});
98
});
99
my $reserve5 = $builder->build({
99
my $reserve5 = $builder->build({
100
    source => 'Reserve',
100
    source => 'Reserve',
101
    value => {
101
    value => {
102
        borrowernumber => $borrowernumber,
102
        borrowernumber => $borrowernumber,
103
        reserve_group_id => 2
103
        hold_group_id => 2
104
    }
104
    }
105
});
105
});
106
my $reserve6 = $builder->build({
106
my $reserve6 = $builder->build({
107
    source => 'Reserve',
107
    source => 'Reserve',
108
    value => {
108
    value => {
109
        borrowernumber => $borrowernumber,
109
        borrowernumber => $borrowernumber,
110
        reserve_group_id => 2
110
        hold_group_id => 2
111
    }
111
    }
112
});
112
});
113
113
114
- 

Return to bug 15516