@@ -, +, @@ cannot be removed from course reserves --------- the existing javascript (eg. Ka-boom:Ka-boom!KABOOM@#$!) -- The course listing should have the new teacher listed. -- nothing happens, and inspecting the error console gives you the ugly error described in comment #0 -- name is removed. -- the course listing no longer lists the new teacher. works as expected. --- course_reserves/mod_course.pl | 2 +- .../prog/en/modules/course_reserves/course.tt | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) --- a/course_reserves/mod_course.pl +++ a/course_reserves/mod_course.pl @@ -62,7 +62,7 @@ if ( $action eq 'del' ) { my @instructors = $cgi->multi_param('instructors'); ModCourseInstructors( mode => 'replace', - cardnumbers => \@instructors, + borrowernumbers => \@instructors, course_id => $new_course_id ); print $cgi->redirect("/cgi-bin/koha/course_reserves/course-details.pl?course_id=$new_course_id"); --- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt +++ a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt @@ -79,8 +79,8 @@ Instructors:
-
[% FOREACH i IN instructors %]
[% i.surname | html %], [% i.firstname | html %] ( Remove ) -
[% END %]
+
[% FOREACH i IN instructors %]
[% i.surname | html %], [% i.firstname | html %] ( Remove ) +
[% END %]
@@ -150,7 +150,7 @@ source: "/cgi-bin/koha/circ/ysearch.pl", minLength: 3, select: function( event, ui ) { - AddInstructor( ui.item.surname + ", " + ui.item.firstname, ui.item.cardnumber ); + AddInstructor( ui.item.surname + ", " + ui.item.firstname, ui.item.borrowernumber ); return false; } }) @@ -168,21 +168,21 @@ $("body").on("click",".removeInstructor",function(e){ e.preventDefault(); var divid = $(this).parent().attr("id"); - var cardnumber = divid.replace("borrower_",""); - RemoveInstructor(cardnumber); + var borrowernumber = divid.replace("borrower_",""); + RemoveInstructor(borrowernumber); }); }); - function AddInstructor( name, cardnumber ) { - div = "
" + name + " ( " + _("Remove")+ " )
"; + function AddInstructor( name, borrowernumber ) { + div = "
" + name + " ( " + _("Remove")+ " )
"; $('#instructors').append( div ); $('#find_instructor').val('').focus(); $('#course_instructors').show(); } - function RemoveInstructor( cardnumber ) { - $( '#borrower_' + cardnumber ).remove(); + function RemoveInstructor( borrowernumber ) { + $( '#borrower_' + borrowernumber ).remove(); if ( ! $('#instructors').html() ) { $('#course_instructors').hide( 800 ); --