Bugzilla – Attachment 79640 Details for
Bug 18887
Introduce new table 'circulation_rules', use for 'max_holds' rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18887: Replace croak with exceptions
Bug-18887-Replace-croak-with-exceptions.patch (text/plain), 2.05 KB, created by
Jonathan Druart
on 2018-09-29 21:20:30 UTC
(
hide
)
Description:
Bug 18887: Replace croak with exceptions
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-09-29 21:20:30 UTC
Size:
2.05 KB
patch
obsolete
>From 10a40d98241835153a3464939fcffb81a556e9fb Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sat, 29 Sep 2018 18:17:52 -0300 >Subject: [PATCH] Bug 18887: Replace croak with exceptions > >--- > Koha/CirculationRules.pm | 22 +++++++++------------- > 1 file changed, 9 insertions(+), 13 deletions(-) > >diff --git a/Koha/CirculationRules.pm b/Koha/CirculationRules.pm >index c34fd2806c..c800673fcf 100644 >--- a/Koha/CirculationRules.pm >+++ b/Koha/CirculationRules.pm >@@ -20,8 +20,7 @@ package Koha::CirculationRules; > > use Modern::Perl; > >-use Carp qw(croak); >- >+use Koha::Exceptions; > use Koha::CirculationRule; > > use base qw(Koha::Objects); >@@ -48,7 +47,9 @@ sub get_effective_rule { > my $itemtype = $params->{itemtype}; > my $branchcode = $params->{branchcode}; > >- croak q{No rule name passed in!} unless $rule_name; >+ Koha::Exceptions::MissingParameter->throw( >+ "Required parameter 'rule_name' missing") >+ unless $rule_name; > > for my $v ( $branchcode, $categorycode, $itemtype ) { > $v = undef if $v and $v eq '*'; >@@ -81,16 +82,11 @@ sub get_effective_rule { > sub set_rule { > my ( $self, $params ) = @_; > >- croak q{set_rule requires the parameter 'branchcode'!} >- unless exists $params->{branchcode}; >- croak q{set_rule requires the parameter 'categorycode'!} >- unless exists $params->{categorycode}; >- croak q{set_rule requires the parameter 'itemtype'!} >- unless exists $params->{itemtype}; >- croak q{set_rule requires the parameter 'rule_name'!} >- unless exists $params->{rule_name}; >- croak q{set_rule requires the parameter 'rule_value'!} >- unless exists $params->{rule_value}; >+ for my $mandatory_parameter (qw( branchcode categorycode itemtype rule_name rule_value ) ){ >+ Koha::Exceptions::MissingParameter->throw( >+ "Required parameter 'branchcode' missing") >+ unless exists $params->{$mandatory_parameter}; >+ } > > my $branchcode = $params->{branchcode}; > my $categorycode = $params->{categorycode}; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18887
:
65233
|
65234
|
65235
|
65236
|
65237
|
67620
|
70986
|
70987
|
70988
|
70989
|
70990
|
70991
|
71031
|
71042
|
72218
|
72219
|
72220
|
72221
|
72222
|
72223
|
72224
|
77080
|
77081
|
77082
|
77083
|
77084
|
77085
|
77086
|
77087
|
77207
|
77208
|
77209
|
77210
|
77211
|
77212
|
77213
|
77214
|
77215
|
77218
|
77238
|
77649
|
77650
|
77651
|
77652
|
77653
|
77654
|
77655
|
77656
|
77657
|
77658
|
77659
|
78346
|
78347
|
78348
|
78349
|
78350
|
78351
|
78352
|
78353
|
78354
|
78355
|
78356
|
78674
|
78675
|
78676
|
78677
|
78678
|
78679
|
78680
|
78681
|
78682
|
78683
|
78684
|
78743
|
78744
|
78745
|
78746
|
78747
|
78748
|
78749
|
78750
|
78751
|
78752
|
78753
|
78879
|
79119
|
79626
|
79627
|
79628
|
79629
|
79630
|
79631
|
79632
|
79633
|
79634
|
79635
|
79636
|
79637
|
79638
|
79639
|
79640
|
79641
|
79761
|
79762
|
79763
|
79764
|
79765
|
79766
|
79767
|
79768
|
79769
|
79770
|
79771
|
79772
|
79773
|
79774
|
79775
|
79776
|
79778
|
79891