Bugzilla – Attachment 79667 Details for
Bug 21425
basketno not being interpolated into error message
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21425 Display basketno correctly in Order error msg
Bug-21425-Display-basketno-correctly-in-Order-erro.patch (text/plain), 1.46 KB, created by
Jonathan Druart
on 2018-09-30 23:21:21 UTC
(
hide
)
Description:
Bug 21425 Display basketno correctly in Order error msg
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-09-30 23:21:21 UTC
Size:
1.46 KB
patch
obsolete
>From f34bc437cb3018542ebd17945578db4632864dd7 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 27 Sep 2018 12:25:28 +0100 >Subject: [PATCH] Bug 21425 Display basketno correctly in Order error msg > >carp will display the hash value instead of the desired basketno >in the error message unless we change its behaviour > >Use the simpler but effective option of concatenating >the errormessage with the basketno. Error is shown if no >sender or receipient ean is passed in instantiating >an Koha::Edifact::Order object > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > Koha/Edifact/Order.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/Edifact/Order.pm b/Koha/Edifact/Order.pm >index dcab51dede..9822526a3b 100644 >--- a/Koha/Edifact/Order.pm >+++ b/Koha/Edifact/Order.pm >@@ -60,13 +60,13 @@ sub new { > return; > } > if ( !$self->{recipient} ) { >- carp >-"No vendor passed to order creation: basket = $self->{basket}->basketno()"; >+ carp 'No vendor passed to order creation: basket = ' >+ . $self->{basket}->basketno; > return; > } > if ( !$self->{sender} ) { >- carp >-"No sender ean passed to order creation: basket = $self->{basket}->basketno()"; >+ carp 'No sender ean passed to order creation: basket = ' >+ . $self->{basket}->basketno; > return; > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21425
:
79480
|
79487
| 79667