Bugzilla – Attachment 79891 Details for
Bug 18887
Introduce new table 'circulation_rules', use for 'max_holds' rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18887: Make DB update idempotent
Bug-18887-Make-DB-update-idempotent.patch (text/plain), 2.41 KB, created by
Jonathan Druart
on 2018-10-03 14:05:34 UTC
(
hide
)
Description:
Bug 18887: Make DB update idempotent
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-10-03 14:05:34 UTC
Size:
2.41 KB
patch
obsolete
>From 361369f3ee3c1f1849fd6a255db47e0a338cf094 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 3 Oct 2018 11:04:45 -0300 >Subject: [PATCH] Bug 18887: Make DB update idempotent > >--- > installer/data/mysql/atomicupdate/bug_18887.perl | 39 +++++++++++++----------- > 1 file changed, 22 insertions(+), 17 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_18887.perl b/installer/data/mysql/atomicupdate/bug_18887.perl >index 97eb1efa42..3d38b57e14 100644 >--- a/installer/data/mysql/atomicupdate/bug_18887.perl >+++ b/installer/data/mysql/atomicupdate/bug_18887.perl >@@ -21,23 +21,28 @@ if( CheckVersion( $DBversion ) ) { > }); > } > >- $dbh->do(q{ >- INSERT INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) >- SELECT branchcode, categorycode, NULL, 'max_holds', COALESCE( max_holds, '' ) FROM branch_borrower_circ_rules >- }); >- >- $dbh->do(q{ >- INSERT INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) >- SELECT NULL, categorycode, NULL, 'max_holds', COALESCE( max_holds, '' ) FROM default_borrower_circ_rules >- }); >- >- $dbh->do(q{ >- ALTER TABLE branch_borrower_circ_rules DROP COLUMN max_holds >- }); >- >- $dbh->do(q{ >- ALTER TABLE default_borrower_circ_rules DROP COLUMN max_holds >- }); >+ >+ if (column_exists('branch_borrower_circ_rules', 'max_holds') ){ >+ $dbh->do(q{ >+ INSERT IGNORE INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) >+ SELECT branchcode, categorycode, NULL, 'max_holds', COALESCE( max_holds, '' ) FROM branch_borrower_circ_rules >+ }); >+ >+ $dbh->do(q{ >+ ALTER TABLE branch_borrower_circ_rules DROP COLUMN max_holds >+ }); >+ } >+ >+ if (column_exists('default_borrower_circ_rules', 'max_holds') ){ >+ $dbh->do(q{ >+ INSERT IGNORE INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) >+ SELECT NULL, categorycode, NULL, 'max_holds', COALESCE( max_holds, '' ) FROM default_borrower_circ_rules >+ }); >+ >+ $dbh->do(q{ >+ ALTER TABLE default_borrower_circ_rules DROP COLUMN max_holds >+ }); >+ } > > SetVersion( $DBversion ); > print "Upgrade to $DBversion done (Bug 18887 - Introduce new table 'circulation_rules', use for 'max_holds' rules)\n"; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18887
:
65233
|
65234
|
65235
|
65236
|
65237
|
67620
|
70986
|
70987
|
70988
|
70989
|
70990
|
70991
|
71031
|
71042
|
72218
|
72219
|
72220
|
72221
|
72222
|
72223
|
72224
|
77080
|
77081
|
77082
|
77083
|
77084
|
77085
|
77086
|
77087
|
77207
|
77208
|
77209
|
77210
|
77211
|
77212
|
77213
|
77214
|
77215
|
77218
|
77238
|
77649
|
77650
|
77651
|
77652
|
77653
|
77654
|
77655
|
77656
|
77657
|
77658
|
77659
|
78346
|
78347
|
78348
|
78349
|
78350
|
78351
|
78352
|
78353
|
78354
|
78355
|
78356
|
78674
|
78675
|
78676
|
78677
|
78678
|
78679
|
78680
|
78681
|
78682
|
78683
|
78684
|
78743
|
78744
|
78745
|
78746
|
78747
|
78748
|
78749
|
78750
|
78751
|
78752
|
78753
|
78879
|
79119
|
79626
|
79627
|
79628
|
79629
|
79630
|
79631
|
79632
|
79633
|
79634
|
79635
|
79636
|
79637
|
79638
|
79639
|
79640
|
79641
|
79761
|
79762
|
79763
|
79764
|
79765
|
79766
|
79767
|
79768
|
79769
|
79770
|
79771
|
79772
|
79773
|
79774
|
79775
|
79776
|
79778
| 79891