From b2a980d5c6e68b7a3745d511b87071a718a05a9a Mon Sep 17 00:00:00 2001
From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Date: Wed, 3 Oct 2018 12:05:40 +0100
Subject: [PATCH] Bug 20941: (follow-up) Carry out comment #4 advice

- Switch getType -> get_type
- get_type now returns a type or undef
- Ternary now performed in template

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
---
 Koha/Illrequest.pm                                           | 10 +++++-----
 koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt  |  6 ++++--
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt |  6 ++++--
 t/db_dependent/Illrequests.t                                 |  8 ++++----
 4 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm
index 104df11683..0fab257942 100644
--- a/Koha/Illrequest.pm
+++ b/Koha/Illrequest.pm
@@ -724,18 +724,18 @@ sub getPrefix {
         || "";                  # "the empty prefix"
 }
 
-=head3 getType
+=head3 get_type
 
-    my $type = $abstract->getType();
+    my $type = $abstract->get_type();
 
-Return a string representing the material type of this request
+Return a string representing the material type of this request or undef
 
 =cut
 
-sub getType {
+sub get_type {
     my ($self) = @_;
     my $attr = $self->illrequestattributes->find({ type => 'type'});
-    return $attr ? $attr->value : '<span>N/A</span>';
+    return $attr ? $attr->value : undef;
 };
 
 #### Illrequests Imports
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
index f6c6a191f2..1157b0daf0 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
@@ -412,6 +412,7 @@
                         <fieldset class="rows">
                             <legend>Request details</legend>
                             <ol>
+                                [% type = request.get_type %]
                                 <li class="borrowernumber">
                                     <label for="borrowernumber">Patron ID:</label>
                                     <input name="borrowernumber" id="borrowernumber" type="text" value="[% request.borrowernumber | html %]">
@@ -437,7 +438,7 @@
                                 </li>
                                 <li class="medium">
                                     <label class="medium">Request type:</label>
-                                    [% request.getType | html %]
+                                    [% type ? type : 'N/A' | html %]
                                 </li>
                                 <li class="cost">
                                     <label class="cost">Cost:</label>
@@ -537,7 +538,8 @@
                                 </div>
                                 <div class="medium">
                                     <span class="label medium">Request type:</span>
-                                    [% request.getType | html %]
+                                    [% type = request.get_type  %]
+                                    [% type ? type : 'N/A' | html %]
                                 </div>
                                 <div class="cost">
                                     <span class="label cost">Cost:</span>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
index a94a168f3e..6345a6e6fc 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt
@@ -124,11 +124,12 @@
                         <tbody>
                             [% FOREACH request IN requests %]
                                 [% status = request.status | html %]
+                                [% type = request.get_type %]
                                 <tr>
                                     <td>[% request.metadata.Author || 'N/A' | html %]</td>
                                     <td>[% request.metadata.Title || 'N/A' | html %]</td>
                                     <td>[% request.backend | html %]</td>
-                                    <td>[% request.getType | html %]</td>
+                                    <td>[% type ? type : '<span>N/A</span>' | html %]</td>
                                     <td>[% request.capabilities.$status.name | html %]</td>
                                     <td>[% request.placed | html %]</td>
                                     <td>[% request.updated | html %]</td>
@@ -147,6 +148,7 @@
                             <fieldset class="rows">
                                 <legend id="library_legend">Details from library</legend>
                                 <ol>
+                                    [% type = request.get_type %]
                                     <li>
                                         <label for="backend">Requested from:</label>
                                         [% request.backend | html %]
@@ -167,7 +169,7 @@
                                     </li>
                                     <li>
                                         <label for="medium">Request type:</label>
-                                        [% request.getType | html %]
+                                        [% type ? type : '<span>N/A</span>' | html %]
                                     </li>
                                     <li>
                                         <label for="placed">Request placed:</label>
diff --git a/t/db_dependent/Illrequests.t b/t/db_dependent/Illrequests.t
index 511bff492d..97df6d85f3 100644
--- a/t/db_dependent/Illrequests.t
+++ b/t/db_dependent/Illrequests.t
@@ -83,8 +83,8 @@ subtest 'Basic object tests' => sub {
     is($illrq_obj->backend, $illrq->{backend},
        "Backend getter works.");
 
-    is($illrq_obj->getType, '<span>N/A</span>',
-        'getType() returns placeholder if no type is set');
+    is($illrq_obj->get_type, '<span>N/A</span>',
+        'get_type() returns placeholder if no type is set');
     $builder->build({
         source => 'Illrequestattribute',
         value  => {
@@ -93,8 +93,8 @@ subtest 'Basic object tests' => sub {
             value => 'book'
         }
     });
-    is($illrq_obj->getType, 'book',
-        'getType() returns correct type if set');
+    is($illrq_obj->get_type, 'book',
+        'get_type() returns correct type if set');
 
     isnt($illrq_obj->status, 'COMP',
          "ILL is not currently marked complete.");
-- 
2.11.0