From 6a91a29fb1444f6f7d8e1f88d6174a2219a7a51a Mon Sep 17 00:00:00 2001 From: Josef Moravec Date: Thu, 4 Oct 2018 07:44:53 +0000 Subject: [PATCH] Bug 20941: (QA follow-up) Fix return value of get_type, make templates more consistant Signed-off-by: Josef Moravec --- Koha/Illrequest.pm | 3 ++- koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 6 +++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 4 ++-- t/db_dependent/Illrequests.t | 4 ++-- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm index 0fab257942..076ff3ddd3 100644 --- a/Koha/Illrequest.pm +++ b/Koha/Illrequest.pm @@ -735,7 +735,8 @@ Return a string representing the material type of this request or undef sub get_type { my ($self) = @_; my $attr = $self->illrequestattributes->find({ type => 'type'}); - return $attr ? $attr->value : undef; + return if !$attr; + return $attr->value; }; #### Illrequests Imports diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt index 1157b0daf0..2e199a486f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt @@ -438,7 +438,7 @@
  • - [% type ? type : 'N/A' | html %] + [% type || 'N/A' | html %]
  • @@ -538,8 +538,8 @@
    Request type: - [% type = request.get_type %] - [% type ? type : 'N/A' | html %] + % type = request.get_type %] + [% type || 'N/A' | html %]
    Cost: diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt index 6345a6e6fc..c5ff708c10 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt @@ -129,7 +129,7 @@ [% request.metadata.Author || 'N/A' | html %] [% request.metadata.Title || 'N/A' | html %] [% request.backend | html %] - [% type ? type : 'N/A' | html %] + [% type || 'N/A' | html %] [% request.capabilities.$status.name | html %] [% request.placed | html %] [% request.updated | html %] @@ -169,7 +169,7 @@
  • - [% type ? type : 'N/A' | html %] + [% type || 'N/A' | html %]
  • diff --git a/t/db_dependent/Illrequests.t b/t/db_dependent/Illrequests.t index 97df6d85f3..523dedb230 100644 --- a/t/db_dependent/Illrequests.t +++ b/t/db_dependent/Illrequests.t @@ -83,8 +83,8 @@ subtest 'Basic object tests' => sub { is($illrq_obj->backend, $illrq->{backend}, "Backend getter works."); - is($illrq_obj->get_type, 'N/A', - 'get_type() returns placeholder if no type is set'); + is($illrq_obj->get_type, undef, + 'get_type() returns undef if no type is set'); $builder->build({ source => 'Illrequestattribute', value => { -- 2.11.0