Bugzilla – Attachment 80557 Details for
Bug 21479
Removing from cart removes 2 items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21479: Remove the trace if the node does not exist
Bug-21479-Remove-the-trace-if-the-node-does-not-ex.patch (text/plain), 1.82 KB, created by
Jonathan Druart
on 2018-10-12 18:38:58 UTC
(
hide
)
Description:
Bug 21479: Remove the trace if the node does not exist
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-10-12 18:38:58 UTC
Size:
1.82 KB
patch
obsolete
>From c994f370b1c86f027cbef3abda4d2a7c92cbd371 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 12 Oct 2018 15:37:44 -0300 >Subject: [PATCH] Bug 21479: Remove the trace if the node does not exist > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/selenium/regressions.t | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > >diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t >index fcef28b609..5d62842a69 100644 >--- a/t/db_dependent/selenium/regressions.t >+++ b/t/db_dependent/selenium/regressions.t >@@ -60,17 +60,13 @@ subtest 'OPAC - Remove from cart' => sub { > > $driver->get( $opac_base_url . "opac-search.pl?q=d" ); > >- my $basket_count_elt; >- eval { >- # FIXME This will produce a STRACE >- # A better way to do that would be to modify the way we display the basket count >- # We should show/hide the count instead or recreate the node >- $basket_count_elt = $driver->find_element('//span[@id="basketcount"]/span') >- }; >- like($@, qr{An element could not be located on the page}, 'Basket should be empty'); >+ # A better way to do that would be to modify the way we display the basket count >+ # We should show/hide the count instead or recreate the node >+ my @basket_count_elts = $driver->find_elements('//span[@id="basketcount"]/span'); >+ is( scalar(@basket_count_elts), 0, 'Basket should be empty'); > > $driver->find_element('//a[@class="addtocart cart1"]')->click; >- $basket_count_elt = $driver->find_element('//span[@id="basketcount"]/span'); >+ my $basket_count_elt = $driver->find_element('//span[@id="basketcount"]/span'); > is( $basket_count_elt->get_text(), > 1, 'One element should have been added to the cart' ); > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21479
:
79852
|
79857
|
79893
|
79903
|
79950
|
80219
|
80291
|
80292
|
80304
|
80305
| 80557 |
80605
|
80625
|
80643