From 88992cb514886a7c67a24e2da7c104d51a27e6e2 Mon Sep 17 00:00:00 2001 From: Andrew Isherwood Date: Wed, 27 Jun 2018 17:13:27 +0100 Subject: [PATCH] Bug 20968: (follow-up) Respond to feedback This patch: - Removes the unecessary testing for intranet_catalog_biblio_enhancements method in detail.pl - Renames get_toolbar_button to get_intranet_catalog_toolbar_button Signed-off-by: Stephen Graham Signed-off-by: Kyle M Hall --- catalogue/detail.pl | 5 ++--- koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/catalogue/detail.pl b/catalogue/detail.pl index 2707a81d36..73c37c6199 100755 --- a/catalogue/detail.pl +++ b/catalogue/detail.pl @@ -65,11 +65,10 @@ my ( $template, $borrowernumber, $cookie, $flags ) = get_template_and_user( # Determine if we should be offering any enhancement plugin buttons if ( C4::Context->preference('UseKohaPlugins') && C4::Context->config('enable_plugins') ) { + # Only pass plugins that can offer a toolbar button my @plugins = Koha::Plugins->new()->GetPlugins({ - method => 'intranet_catalog_biblio_enhancements' + method => 'get_intranet_catalog_toolbar_button' }); - # Only pass plugins that can offer a toolbar button - @plugins = grep { $_->get_toolbar_button } @plugins; $template->param( plugins => \@plugins ); diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc index 935f94feff..e1552dd1fc 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc @@ -140,7 +140,7 @@ CAN_user_serials_create_subscription ) %] [% END %] [% FOREACH p IN plugins %] - [% p.get_toolbar_button %] + [% p.get_intranet_catalog_toolbar_button %] [% END %] -- 2.17.1 (Apple Git-112)