Bugzilla – Attachment 80667 Details for
Bug 18959
Text_CSV_Various.t must skip if Text::CSV::Unicode is not installed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18959: Skip xt/author/Text_CSV_Various.t if Text::CSV::Unicode missing
Bug-18959-Skip-xtauthorTextCSVVarioust-if-TextCSVU.patch (text/plain), 1.26 KB, created by
Jonathan Druart
on 2018-10-16 16:39:04 UTC
(
hide
)
Description:
Bug 18959: Skip xt/author/Text_CSV_Various.t if Text::CSV::Unicode missing
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-10-16 16:39:04 UTC
Size:
1.26 KB
patch
obsolete
>From 8593064bf1a66dc50c6f740f29e4a6695ef6a5d5 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Sat, 13 Oct 2018 09:17:00 -0300 >Subject: [PATCH] Bug 18959: Skip xt/author/Text_CSV_Various.t if > Text::CSV::Unicode missing > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > xt/author/Text_CSV_Various.t | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) > >diff --git a/xt/author/Text_CSV_Various.t b/xt/author/Text_CSV_Various.t >index f7f8ff966e..23b1f91db2 100755 >--- a/xt/author/Text_CSV_Various.t >+++ b/xt/author/Text_CSV_Various.t >@@ -22,16 +22,24 @@ > > use Modern::Perl; > >-use Test::More tests => 32; >+use Test::More; > use Test::Warn; >+ >+use Text::CSV; >+use Text::CSV_XS; >+ >+use Module::Load::Conditional qw/check_install/; >+ > BEGIN { >- use FindBin; >- use lib $FindBin::Bin; >- use_ok('Text::CSV'); >- use_ok('Text::CSV_XS'); >- use_ok('Text::CSV::Unicode'); >+ if ( check_install( module => 'Text::CSV::Unicode' ) ) { >+ plan tests => 29; >+ } else { >+ plan skip_all => "Need Text::CSV::Unicode" >+ } > } > >+use Text::CSV::Unicode; >+ > sub pretty_line { > my $max = 54; > (@_) or return "#" x $max . "\n"; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18959
:
80578
|
80579
|
80666
| 80667