From 46ae8b1c765ae9de87d60cd020b5601f43f02a88 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 16 Oct 2018 17:09:29 +0000 Subject: [PATCH] Bug 21583: Don't use Asset.js for external script files To test: 1 - Enable Novelist in staff client: NovelistSelectStaffEnabled: Add NovelistSelectStaffProfile: anything NovelistSelectPassword: anything ( these don't need to be valid, just not blank ) 2 - Pull up a record detail page in staff client 3 - View page source - search for ns2init.js 4 - You won't find it 5 - Apply patch 6 - Reload details 7 - Search page source for ns2init.js 8 - It loaded! Huzzah! --- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index 4dddbe4..451c105 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -1080,7 +1080,7 @@ });[% END %] [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && ( normalized_isbn || normalized_upc ) ) %] - [% Asset.js("https://imageserver.ebscohost.com/novelistselect/ns2init.js") | $raw %] + [% END %] [% INCLUDE 'datatables.inc' %] [% Asset.js("lib/jquery/plugins/jquery.dataTables.columnFilter.js") | $raw %] -- 2.1.4