Bugzilla – Attachment 80829 Details for
Bug 21597
Test suite is still failing with new default SQL modes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21597: Column 'notforloan' cannot be null
Bug-21597-Column-notforloan-cannot-be-null.patch (text/plain), 1.96 KB, created by
Nick Clemens
on 2018-10-18 13:04:33 UTC
(
hide
)
Description:
Bug 21597: Column 'notforloan' cannot be null
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2018-10-18 13:04:33 UTC
Size:
1.96 KB
patch
obsolete
>From fbf0cf1758ff004a682a75d98a6e503cbe2efff6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 17 Oct 2018 19:07:20 -0300 >Subject: [PATCH] Bug 21597: Column 'notforloan' cannot be null > >Fix t/db_dependent/Circulation.t > >items.notforloan: > `notforloan` tinyint(1) NOT NULL DEFAULT '0', > >t/db_dependent/Circulation.t .. 115/119 DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. > # No tests run! > > # Failed test 'No tests run for subtest "item-level_itypes = 0"' > # at t/db_dependent/Circulation.t line 2356. > # Looks like you failed 1 test of 2. > > # Failed test 'CanBookBeIssued | notforloan' > # at t/db_dependent/Circulation.t line 2359. >Can't locate object method "rethrow" via package "DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/Circulation.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 09d4d0a..817461b 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -2327,7 +2327,7 @@ subtest 'CanBookBeIssued | notforloan' => sub { > ); > > # for loan at item type and item level >- $item->notforloan(undef)->store; >+ $item->notforloan(0)->store; > $item->biblioitem->itemtype($itemtype->{itemtype})->store; > ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef ); > is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21597
:
80812
|
80813
|
80814
|
80815
|
80816
|
80821
|
80829
|
80830
|
80831
|
80832
|
80833
|
80834
|
80852
|
80853
|
80854
|
80855
|
80856
|
80857