From e946fe2b07d199d770c6a0c8f98d666396f461f9 Mon Sep 17 00:00:00 2001 From: Alex Buckley Date: Wed, 17 Oct 2018 13:34:21 +0000 Subject: [PATCH] Bug 20844: Fixed error when cancelling hold from cataloguing/additem.pl Also fixed qa test tool failure on C4/Circulation.pm Sponsored-By: Brimbank Library, Australia --- C4/Circulation.pm | 1 - cataloguing/additem.pl | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index d7af3a7..139ccb5 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -3687,7 +3687,6 @@ sub LostItem{ my ( $restype, $res ) = C4::Reserves::CheckReserves( $itemnumber ); my $LostItemLevelHold; - my $transfers; if ( $restype eq "Waiting" || $restype eq "Reserved" ) { if ( $res->{originalholdtype} eq "B" ) { #originalholdtype equalling "B" means this is a bib level hold diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl index 3661878..9d32e54 100755 --- a/cataloguing/additem.pl +++ b/cataloguing/additem.pl @@ -717,7 +717,7 @@ if ($op eq "additem") { if ($LostItemLevelHold) { $lostitemnumber = $originalitemnumber; } - $template->param( LostItemLevelHold => $LostItemLevelHold, itemnumber => $originalitemnumber ); + $template->param( LostItemLevelHold => $LostItemLevelHold, lostitemnumber => $lostitemnumber ); $nextop="additem"; } elsif ($op eq "delinkitem"){ my $analyticfield = '773'; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt index 862039f..4c68c97 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ -263,8 +263,8 @@ function confirm_deletion() { [% IF (LostItemLevelHold) %]
- - This item has an item-level hold on it: + + This item has an item-level hold on [% itemnumber | html %] it:
-- 2.1.4