Bugzilla – Attachment 80904 Details for
Bug 21613
Turn strict SQL modes on for tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21613: (QA follow-up) Resolve warning on $ENV{_}
Bug-21613-QA-follow-up-Resolve-warning-on-ENV.patch (text/plain), 1.43 KB, created by
Marcel de Rooy
on 2018-10-19 08:23:14 UTC
(
hide
)
Description:
Bug 21613: (QA follow-up) Resolve warning on $ENV{_}
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-10-19 08:23:14 UTC
Size:
1.43 KB
patch
obsolete
>From f187a8ff37f4c02cc872d6d291b62daa9633f7fc Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 19 Oct 2018 10:15:56 +0200 >Subject: [PATCH] Bug 21613: (QA follow-up) Resolve warning on $ENV{_} >Content-Type: text/plain; charset=utf-8 > >Some shells may not pass the program name in underscore, and cron also >does not like it here: >Use of uninitialized value $ENV{"_"} in pattern match (m//) at Koha/Database.pm line 79. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Database.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Database.pm b/Koha/Database.pm >index 1da498f..2d6110a 100644 >--- a/Koha/Database.pm >+++ b/Koha/Database.pm >@@ -76,7 +76,7 @@ sub _new_schema { > %encoding_attr = ( mysql_enable_utf8 => 1 ); > $encoding_query = "set NAMES 'utf8mb4'"; > $tz_query = qq(SET time_zone = "$tz") if $tz; >- if ( $ENV{_} =~ m|prove| or C4::Context->config('strict_sql_modes') ) { >+ if ( ( $ENV{_} && $ENV{_} =~ m|prove| ) or C4::Context->config('strict_sql_modes') ) { > $sql_mode_query = q{SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'}; > } else { > $sql_mode_query = q{SET sql_mode = 'IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'}; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21613
:
80887
|
80888
|
80896
|
80897
|
80904
|
80936
|
80937
|
81387
|
81388
|
81389
|
81390