Bugzilla – Attachment 80983 Details for
Bug 19893
Alternative optimized indexing for Elasticsearch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19893: Fixed some typos
Bug-19893-Fixed-some-typos.patch (text/plain), 2.80 KB, created by
David Gustafsson
on 2018-10-22 14:54:17 UTC
(
hide
)
Description:
Bug 19893: Fixed some typos
Filename:
MIME Type:
Creator:
David Gustafsson
Created:
2018-10-22 14:54:17 UTC
Size:
2.80 KB
patch
obsolete
>From 1c4543fe091c40745c59648b3b2e3925f0321263 Mon Sep 17 00:00:00 2001 >From: David Gustafsson <david.gustafsson@ub.gu.se> >Date: Mon, 22 Oct 2018 16:52:18 +0200 >Subject: [PATCH] Bug 19893: Fixed some typos > >--- > Koha/SearchEngine/Elasticsearch.pm | 6 +++--- > Koha/SearchEngine/Elasticsearch/Indexer.pm | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/Koha/SearchEngine/Elasticsearch.pm b/Koha/SearchEngine/Elasticsearch.pm >index 3719f8961d..2e21e969da 100644 >--- a/Koha/SearchEngine/Elasticsearch.pm >+++ b/Koha/SearchEngine/Elasticsearch.pm >@@ -314,7 +314,7 @@ sub sort_fields { > > my @record_documents = $self->marc_records_to_documents($marc_records); > >-Using mappings stored in databse convert C<$marc_records> to ElasticSearch documents. >+Using mappings stored in database convert C<$marc_records> to ElasticSearch documents. > > Returns array of hash references, representing ElasticSearch documents, > acceptable as body payload in C<Search::Elasticsearch> requests. >@@ -457,14 +457,14 @@ sub marc_records_to_documents { > > my $mapping_rules = $self->_get_marc_mapping_rules() > >-Generates rules from mappings stored in databse for MARC records to Elasticsearch JSON document conversion. >+Generates rules from mappings stored in database for MARC records to Elasticsearch JSON document conversion. > > Since field retrieval is slow in C<MARC::Records> (all fields are itereted through for > each call to C<MARC::Record>->field) we create an optimized structure of mapping > rules keyed by MARC field tags holding all the mapping rules for that particular tag. > > We can then iterate through all MARC fields for each record and apply all relevant >-rules once per fields instead of retreiving field multiple times for each mapping rule >+rules once per fields instead of retreiving fields multiple times for each mapping rule > wich is terribly slow. > > =cut >diff --git a/Koha/SearchEngine/Elasticsearch/Indexer.pm b/Koha/SearchEngine/Elasticsearch/Indexer.pm >index 4646e0b94f..9836d3e9cc 100644 >--- a/Koha/SearchEngine/Elasticsearch/Indexer.pm >+++ b/Koha/SearchEngine/Elasticsearch/Indexer.pm >@@ -81,7 +81,7 @@ use constant { > die("Something whent wrong trying to update index:" . $_[0]); > } > >-Converts C<MARC::Records> C<$records> to Elasticsearch documents and perform >+Converts C<MARC::Records> C<$records> to Elasticsearch documents and performs > an update request for these records on the Elasticsearch index. > > The values in the arrays must match up, and the 999$c value in the MARC record >@@ -96,8 +96,8 @@ If that's a problem, clone them first. > > =item C<$biblionums> > >-Arrayref of biblio numbers for the C<$records>, the order must be the same >-as C<$records>. >+Arrayref of biblio numbers for the C<$records>, the order must be the same as >+and match up with C<$records>. > > =item C<$records> > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19893
:
70199
|
70200
|
70201
|
70202
|
70230
|
70325
|
73153
|
75109
|
75271
|
75272
|
75353
|
75428
|
75455
|
75588
|
75658
|
75660
|
76612
|
76613
|
76614
|
76629
|
78091
|
78092
|
78093
|
78094
|
78524
|
78561
|
78587
|
78588
|
78589
|
78590
|
78591
|
78592
|
78593
|
78594
|
78690
|
78691
|
78692
|
78693
|
78694
|
78695
|
78696
|
80969
|
80970
|
80971
|
80983
|
81014
|
81015
|
81284
|
81822
|
81901
|
81903
|
81955
|
81957
|
81958
|
81959
|
81960
|
81961
|
81962
|
81963
|
81964
|
81965
|
81966
|
82143
|
82144
|
82145
|
82146
|
82147
|
82148
|
82149
|
82150
|
82151
|
82152
|
82256
|
82257
|
82258
|
82259
|
82260
|
82261
|
82262
|
82263
|
82264
|
82265
|
82266
|
82267