From ac3e9efc5bcab95d7b1ea55e84a7024d6e222d36 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 16 Oct 2018 15:15:10 -0300 Subject: [PATCH] Bug 21584: Wrong offset type for Lost Item Bug 2696 introduced account_offset_type.inc but 'Lost Item Return' doesn't match what is added on the database. Moreover, bug 20978 added references to this wrong value too in Koha::Account This patch performs a trivial fix for this. Signed-off-by: Tomas Cohen Arazi Patch matches what was outlined in test plan, also passes qa test tool Signed-off-by: Alex Buckley Signed-off-by: Kyle M Hall --- Koha/Account.pm | 2 +- .../intranet-tmpl/prog/en/includes/account_offset_type.inc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Koha/Account.pm b/Koha/Account.pm index 2db8d0d182..e6863979fd 100644 --- a/Koha/Account.pm +++ b/Koha/Account.pm @@ -535,7 +535,7 @@ sub non_issues_charges { our $offset_type = { 'credit' => 'Manual Credit', 'forgiven' => 'Writeoff', - 'lost_item_return' => 'Lost Item Return', + 'lost_item_return' => 'Lost Item', 'payment' => 'Payment', 'writeoff' => 'Writeoff' }; diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc index aecb41504c..94edb239f4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc @@ -3,7 +3,7 @@ [% CASE 'Payment' %]Payment [% CASE 'Manual Credit' %]Manual credit [% CASE 'Manual Debit' %]Manual invoice - [% CASE 'Lost Item Return' %]Lost item returned + [% CASE 'Lost Item' %]Lost item returned [% CASE 'Writeoff' %]Writeoff [% CASE 'Void Payment' %]Void payment [% CASE %][% account_offset.type | html %] -- 2.17.1 (Apple Git-112)