From e9b1173c5bbb5185b2de50279c596124712df433 Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Thu, 25 Oct 2018 10:06:43 +0100 Subject: [PATCH 2/3] Bug 21658 Define string to avoid run time warnings In addition to an explicit error a renewal may be rejected because a fee is due and has not yet been flagged as paid. In this case define the error message as empty string to avoid runtime errors in the regexes performed on the standard error messages --- C4/SIP/ILS/Transaction/Renew.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/C4/SIP/ILS/Transaction/Renew.pm b/C4/SIP/ILS/Transaction/Renew.pm index 7e1e9b7496..83b87ea67b 100644 --- a/C4/SIP/ILS/Transaction/Renew.pm +++ b/C4/SIP/ILS/Transaction/Renew.pm @@ -40,6 +40,8 @@ sub do_renew_for { $self->{fee_amount} = sprintf '%.2f',$fee; if ($self->{fee_ack} eq 'N') { $renewokay = 0; + $renewerror = q{}; # define error string to avoid runtime warnings + # in regexes below } } -- 2.17.2