Bugzilla – Attachment 81128 Details for
Bug 21658
Renew requests fail if a fee attached
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Fix error in value not passed to transaction
0003-Bug-21658-Pass-fee_ack-value-to-Renew-transaction.patch (text/plain), 1.10 KB, created by
Colin Campbell
on 2018-10-25 10:24:18 UTC
(
hide
)
Description:
Fix error in value not passed to transaction
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2018-10-25 10:24:18 UTC
Size:
1.10 KB
patch
obsolete
>From 17b2666b218a9a33fabaa485cc7d8355b515fc9c Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 25 Oct 2018 10:12:08 +0100 >Subject: [PATCH 3/3] Bug 21658 Pass fee_ack value to Renew transaction > >Response to a renew request should mirror that of checkout >However fee_ack was not being passed to the renewal >transaction so that it was always 'N' not allowing >the renewal to proceed even although the fee was paid > >This bug was not seen with many units as they use >checkout requests both for an initial issue and >renewal. Code now passes fee_ack as is done for checkout >--- > C4/SIP/ILS.pm | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index 1bd23c6429..17f58d2447 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -435,6 +435,10 @@ sub renew { > $trans->screen_msg("Renewals not allowed."); > return $trans; > } >+ # pass fee_ack to the transaction >+ if ($fee_ack) { >+ $trans->fee_ack($fee_ack); >+ } > > # Previously: renewing a title, rather than an item (sort of) > # This is gross, but in a real ILS it would be better >-- >2.17.2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21658
:
81126
|
81127
|
81128
|
89487
|
89488