From abf1f5ea21440c88cb517aaf9dad7f9feb884d65 Mon Sep 17 00:00:00 2001 From: Alex Buckley Date: Mon, 2 Jul 2018 15:48:38 +1200 Subject: [PATCH] Bug 19532: Implemented check if recall status equals 'R' before recall popup is shown This stops the 'confirm recall' popup message being displayed upon item return when the item has a recall with any status other than 'R' (recalled). Sponsored-By: Toi Ohomai Institute of Technology, New Zealand --- C4/Circulation.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 7409523..1e4e4de 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -1391,10 +1391,10 @@ sub AddIssue { # Check if a recall if ( C4::Context->preference('UseRecalls') ) { - my $recall = Koha::Recalls->find({ itemnumber => $item->{'itemnumber'}, borrowernumber => $borrower->{'borrowernumber'}, old => undef }); - if (defined $recall) { - $recall->update({ status => "F", old => 1 }); - } + my $recall = Koha::Recalls->find({ itemnumber => $item->{'itemnumber'}, borrowernumber => $borrower->{'borrowernumber'} }); + if (defined $recall) { + $recall->update({ status => 'F', old => 1 }); + } } if ( C4::Context->preference('ReturnToShelvingCart') ) { -- 2.1.4