Bugzilla – Attachment 81390 Details for
Bug 21613
Turn strict SQL modes on for tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21613: (QA follow-up) Resolve warning on $ENV{_} - avoid autovivification
Bug-21613-QA-follow-up-Resolve-warning-on-ENV---av.patch (text/plain), 1.49 KB, created by
Katrin Fischer
on 2018-10-28 09:58:51 UTC
(
hide
)
Description:
Bug 21613: (QA follow-up) Resolve warning on $ENV{_} - avoid autovivification
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-10-28 09:58:51 UTC
Size:
1.49 KB
patch
obsolete
>From 629ffbeaececee8bb8cbb98bdeadf35b7bb5c79d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 19 Oct 2018 11:36:16 -0300 >Subject: [PATCH] Bug 21613: (QA follow-up) Resolve warning on $ENV{_} - avoid > autovivification > >See C4::Circulation::SendCirculationAlert >3355 my $do_not_lock = ( exists $ENV{_} && $ENV{_} =~ m|prove| ) || $ENV{KOHA_NO_TABLE_LOCKS}; > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > Koha/Database.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Database.pm b/Koha/Database.pm >index 2d6110adde..ea8a10a9bb 100644 >--- a/Koha/Database.pm >+++ b/Koha/Database.pm >@@ -76,7 +76,7 @@ sub _new_schema { > %encoding_attr = ( mysql_enable_utf8 => 1 ); > $encoding_query = "set NAMES 'utf8mb4'"; > $tz_query = qq(SET time_zone = "$tz") if $tz; >- if ( ( $ENV{_} && $ENV{_} =~ m|prove| ) or C4::Context->config('strict_sql_modes') ) { >+ if ( ( exists $ENV{_} && $ENV{_} =~ m|prove| ) or C4::Context->config('strict_sql_modes') ) { > $sql_mode_query = q{SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'}; > } else { > $sql_mode_query = q{SET sql_mode = 'IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'}; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21613
:
80887
|
80888
|
80896
|
80897
|
80904
|
80936
|
80937
|
81387
|
81388
|
81389
| 81390