Bugzilla – Attachment 81402 Details for
Bug 21703
Placing holds in staff is broken (TT filter)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21703: Fix filter on dataurl variable to allow placing holds in staff again
Bug-21703-Fix-filter-on-dataurl-variable-to-allow-.patch (text/plain), 1.83 KB, created by
Jonathan Druart
on 2018-10-28 12:02:34 UTC
(
hide
)
Description:
Bug 21703: Fix filter on dataurl variable to allow placing holds in staff again
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-10-28 12:02:34 UTC
Size:
1.83 KB
patch
obsolete
>From 3c90dc2d02c27618133e38a342c8c4dfa15a9d01 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sun, 28 Oct 2018 08:59:51 -0300 >Subject: [PATCH] Bug 21703: Fix filter on dataurl variable to allow placing > holds in staff again > >We must not encode & again and use the url filter, instead of uri. > >To test: >- Search for a record in staff >- Go to holds >- Search for patrons, multiple should be displayed >- Pick a patron by clicking on the name >- Verify an error is shown and the URL is incorrect >- Apply patch >- Repeat test above, placing a hold should now work. >--- > .../intranet-tmpl/prog/en/includes/circ-patron-search-results.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc >index dbad05777e..8e8845b461 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc >@@ -22,8 +22,8 @@ > [% ELSE %] > [% SET data_url = "/cgi-bin/koha/reserve/request.pl?borrowernumber=" _ borrower.borrowernumber _ "&biblionumber=" _ biblionumber %] > [% END %] >- <tr class="clickable" data-url="[% data_url | html %]"> >- <td><a href="[% data_url | uri %]">[% borrower.surname | html %], [% borrower.firstname | html %]</a></td> >+ <tr class="clickable" data-url="[% data_url | url %]"> >+ <td><a href="[% data_url | url %]">[% borrower.surname | html %], [% borrower.firstname | html %]</a></td> > [% END %] > <td>[% borrower.cardnumber | html %]</td> > <td>[% borrower.dateofbirth | $KohaDates %]</td> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21703
:
81375
|
81402
|
81404