Bugzilla – Attachment 81484 Details for
Bug 21711
Remove $shib in Auth.t (17776 folllow-up)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21711: Remove $shib in Auth.t (17776 folllow-up)
Bug-21711-Remove-shib-in-Autht-17776-folllow-up.patch (text/plain), 1.12 KB, created by
Marcel de Rooy
on 2018-10-29 12:44:53 UTC
(
hide
)
Description:
Bug 21711: Remove $shib in Auth.t (17776 folllow-up)
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2018-10-29 12:44:53 UTC
Size:
1.12 KB
patch
obsolete
>From d42018fb3b2dac5c1a33743ec068204aa470f8f6 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 29 Oct 2018 13:43:11 +0100 >Subject: [PATCH] Bug 21711: Remove $shib in Auth.t (17776 folllow-up) >Content-Type: text/plain; charset=utf-8 > >See patch (QA follow-up) Remove shibboleth package variables on bug 17776. >The variable is no longer global and should be removed in Auth.t. >Trivial. > >Resolves warning: >Name "C4::Auth::shib" used only once: possible typo at t/db_dependent/Auth.t line 298. > >Test plan: >Run t/db_dependent/Auth.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Auth.t | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/t/db_dependent/Auth.t b/t/db_dependent/Auth.t >index 5183edf..3cf4651 100644 >--- a/t/db_dependent/Auth.t >+++ b/t/db_dependent/Auth.t >@@ -295,7 +295,6 @@ subtest 'Check value of login_attempts in checkpw' => sub { > # Only interested here in regular login > $C4::Auth::cas = 0; > $C4::Auth::ldap = 0; >- $C4::Auth::shib = 0; > > my $patron = $builder->build_object({ class => 'Koha::Patrons' }); > $patron->login_attempts(2); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21711
: 81484