Bugzilla – Attachment 81645 Details for
Bug 21080
patron attribute classes break patron's edit view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21080: Fix patron's attributes display when PA_CLASS is used
Bug-21080-Fix-patrons-attributes-display-when-PACL.patch (text/plain), 2.44 KB, created by
Katrin Fischer
on 2018-10-31 06:49:07 UTC
(
hide
)
Description:
Bug 21080: Fix patron's attributes display when PA_CLASS is used
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2018-10-31 06:49:07 UTC
Size:
2.44 KB
patch
obsolete
>From 7f325ce0d1d78a3044f1b612f66703369ec82a42 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 29 Oct 2018 19:23:53 -0300 >Subject: [PATCH] Bug 21080: Fix patron's attributes display when PA_CLASS is > used > >When a patron attribute class (AV PA_CLASS) is created, the patron's >edit view is broken: >https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org > >To recreate: >1. Create 1+ authorised values PA_CLASS >2. Create patron's attributes using it >3. Edit a patron > >it depends on the order of the fieldset and the ol elements > >This is certainly not the best fix but the display does not look broken! > >Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index be03649b2a..e72944eb13 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1041,11 +1041,11 @@ > <legend id="patron_attributes_lgd">Additional attributes and identifiers</legend> > <input type="hidden" name="setting_extended_patron_attributes" value="1" /> > [% FOREACH pa_loo IN patron_attributes %] >- [% IF pa_loo.class %] >- <fieldset id="aai_[% pa_loo.class | html %]"> >- <legend id="[% pa_loo.class | html %]_lgd">[% pa_loo.lib | html %]</legend> >- [% END %] > <ol class="attributes_table"> >+ [% IF pa_loo.class %] >+ <fieldset id="aai_[% pa_loo.class | html %]"> >+ <legend id="[% pa_loo.class | html %]_lgd">[% pa_loo.lib | html %]</legend> >+ [% END %] > [% FOREACH patron_attribute IN pa_loo.items %] > <li data-category_code="[% patron_attribute.category_code | html %]"> > <label for="[% patron_attribute.form_id | html %]">[% patron_attribute.description | html %]: </label> >@@ -1074,8 +1074,8 @@ > [% END %] > </li> > [% END %] >+ [% IF pa_loo.class %]</fieldset>[% END %] > </ol> >- [% IF pa_loo.class %]</fieldset>[% END %] > [% END %] > </fieldset> > [% END %][% END %][% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21080
:
81598
|
81617
| 81645