Bugzilla – Attachment 81694 Details for
Bug 20941
Displaying requests does not display request material type
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20941: (follow-up) Switch 'media' -> 'types'
Bug-20941-follow-up-Switch-media---types.patch (text/plain), 1.86 KB, created by
Josef Moravec
on 2018-10-31 09:54:05 UTC
(
hide
)
Description:
Bug 20941: (follow-up) Switch 'media' -> 'types'
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2018-10-31 09:54:05 UTC
Size:
1.86 KB
patch
obsolete
>From 855b685eeea58d403f86c84f7ad12f28f3d17785 Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Mon, 8 Oct 2018 13:33:46 +0100 >Subject: [PATCH] Bug 20941: (follow-up) Switch 'media' -> 'types' > >Clearing up the inconsistency mentioned in comment #35. There is one >place where we use the term 'media' for a template variable, everywhere >we refer to material types as 'types'. > >NOTE: This is a breaking change for existing backends that still use >'media'. Of the PTFS Europe backends, only the Koha backend uses it, >this will be modified as necessary. Generally backends will supply this >variable themselves, so the breaking-ness of this change should be >minimal. > >No test plan as it's backend dependent. > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > ill/ill-requests.pl | 2 +- > opac/opac-illrequests.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl >index a2e898a..3a97969 100755 >--- a/ill/ill-requests.pl >+++ b/ill/ill-requests.pl >@@ -273,7 +273,7 @@ if ( $backends_available ) { > > $template->param( > backends => $backends, >- media => [ "Book", "Article", "Journal" ], >+ types => [ "Book", "Article", "Journal" ], > query_type => $op, > branches => scalar Koha::Libraries->search, > ); >diff --git a/opac/opac-illrequests.pl b/opac/opac-illrequests.pl >index 1fa1ce3..1b7807c 100755 >--- a/opac/opac-illrequests.pl >+++ b/opac/opac-illrequests.pl >@@ -121,7 +121,7 @@ if ( $op eq 'list' ) { > ); > } else { > $template->param( >- media => [ "Book", "Article", "Journal" ], >+ types => [ "Book", "Article", "Journal" ], > branches => Koha::Libraries->search->unblessed, > whole => $backend_result, > request => $request >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20941
:
76052
|
79577
|
79825
|
79865
|
79918
|
79919
|
79920
|
79921
|
79945
|
79999
|
80112
|
80113
|
80114
|
80115
|
80116
|
80117
|
80127
|
80128
|
80129
|
80130
|
80131
|
80132
|
80212
|
81688
|
81689
|
81690
|
81691
|
81692
|
81693
| 81694