View | Details | Raw Unified | Return to bug 21738
Collapse All | Expand All

(-)a/C4/Reserves.pm (-1 / +1 lines)
Lines 283-289 sub CanBookBeReserved{ Link Here
283
        push (@itemnumbers, @hostitems);
283
        push (@itemnumbers, @hostitems);
284
    }
284
    }
285
285
286
    my $canReserve;
286
    my $canReserve = { status => 'NoItems' };
287
    foreach my $itemnumber (@itemnumbers) {
287
    foreach my $itemnumber (@itemnumbers) {
288
        $canReserve = CanItemBeReserved( $borrowernumber, $itemnumber, $pickup_branchcode );
288
        $canReserve = CanItemBeReserved( $borrowernumber, $itemnumber, $pickup_branchcode );
289
        return { status => 'OK' } if $canReserve->{status} eq 'OK';
289
        return { status => 'OK' } if $canReserve->{status} eq 'OK';
(-)a/reserve/request.pl (-6 / +4 lines)
Lines 234-239 foreach my $biblionumber (@biblionumbers) { Link Here
234
                $template->param( $canReserve->{status} => 1 );
234
                $template->param( $canReserve->{status} => 1 );
235
                $biblioloopiter{ $canReserve->{status} } = 1;
235
                $biblioloopiter{ $canReserve->{status} } = 1;
236
            }
236
            }
237
            elsif ( $canReserve->{status} eq 'NoItems' ) {
238
                $template->param('noitems' => 1);
239
                $biblioloopiter{noitems} = 1;
240
            }
237
            else {
241
            else {
238
                $biblioloopiter{ $canReserve->{status} } = 1;
242
                $biblioloopiter{ $canReserve->{status} } = 1;
239
            }
243
            }
Lines 305-316 foreach my $biblionumber (@biblionumbers) { Link Here
305
309
306
    my $items = Koha::Items->search({ -or => { biblionumber => $biblionumber, itemnumber => { in => \@itemnumbers } } });
310
    my $items = Koha::Items->search({ -or => { biblionumber => $biblionumber, itemnumber => { in => \@itemnumbers } } });
307
311
308
    unless ( $items->count ) {
309
        # FIXME Then why do we continue?
310
        $template->param('noitems' => 1);
311
        $biblioloopiter{noitems} = 1;
312
    }
313
314
    ## Here we go backwards again to create hash of biblioitemnumber to itemnumbers,
312
    ## Here we go backwards again to create hash of biblioitemnumber to itemnumbers,
315
    ## when by definition all of the itemnumber have the same biblioitemnumber
313
    ## when by definition all of the itemnumber have the same biblioitemnumber
316
    my ( $iteminfos_of );
314
    my ( $iteminfos_of );
(-)a/t/db_dependent/Reserves/NoItems.t (-1 / +25 lines)
Line 0 Link Here
0
- 
1
#!/usr/bin/perl
2
3
use Modern::Perl;
4
use Test::More tests => 1;
5
6
use C4::Reserves;
7
8
use t::lib::TestBuilder;
9
10
my $schema = Koha::Database->new->schema;
11
$schema->storage->txn_begin;
12
13
$schema->storage->txn_rollback;
14
15
my $builder = t::lib::TestBuilder->new();
16
17
my $biblio = $builder->build({
18
    source => 'Biblio',
19
});
20
21
my $patron = $builder->build({
22
    source => 'Borrower',
23
});
24
25
is( C4::Reserves::CanBookBeReserved($patron->{borrowernumber}, $biblio->{biblionumber})->{status} , 'NoItems', "Reserving a Biblio without items fail." );

Return to bug 21738