From 9a61bb5a54742fe3039440b605ec532e11afad99 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 4 Jan 2018 14:53:14 +0000 Subject: [PATCH] Bug 19915: Add unit test to GetItemsForInventory.t prove -v t/db_dependent/Items/GetItemsForInventory.t Signed-off-by: Anne-Claire Bernaudin Signed-off-by: Marcel de Rooy Moved the betwen typo edit back here. --- t/db_dependent/Items/GetItemsForInventory.t | 42 ++++++++++++++++++++++++++++- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Items/GetItemsForInventory.t b/t/db_dependent/Items/GetItemsForInventory.t index 17ab8c1615..a09359ada5 100755 --- a/t/db_dependent/Items/GetItemsForInventory.t +++ b/t/db_dependent/Items/GetItemsForInventory.t @@ -18,9 +18,11 @@ # along with Koha; if not, see . use Modern::Perl; -use Test::More tests => 6; +use Test::More tests => 7; +use t::lib::TestBuilder; use Koha::AuthorisedValues; +use C4::ClassSource; $| = 1; @@ -43,6 +45,44 @@ my ($newResults, $newCount) = GetItemsForInventory; is_deeply($newResults,$oldResults,"Inventory results unchanged."); $dbh->rollback; +$dbh->{AutoCommit} = 1; + +subtest 'Use cn_sort rather than callnumber to determine correct location' => sub { + + plan tests => 1; + my $builder = t::lib::TestBuilder->new; + my $schema = Koha::Database->new->schema; + $schema->storage->txn_begin; + $builder->schema->resultset( 'Issue' )->delete_all; + $builder->schema->resultset( 'Item' )->delete_all; + + my $class_rule = $builder->build({ + source => 'ClassSortRule', + value => { sort_routine => "LCC" } + }); + my $class_source = $builder->build({ + source => 'ClassSource', + value => { + class_sort_rule => $class_rule->{class_sort_rule}, + } + }); + my $item_1 = $builder->build({ + source => 'Item', + value => { + itemcallnumber => 'GT95', + cn_sort => GetClassSort($class_source->{cn_source},undef,'GT95'), + } + }); + + my( undef, $item_count) = GetItemsForInventory({ + maxlocation => 'GT100', + minlocation => 'GT90', + class_source => $class_source->{cn_source}, + }); + is($item_count,1,"We should return GT95 as between GT90 and GT100"); + $schema->storage->txn_rollback; + +}; sub OldWay { my ($tdbh) = @_; -- 2.11.0