Bugzilla – Attachment 81848 Details for
Bug 15774
Additional fields for baskets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15774: Add missing tests for GetSubscription
Bug-15774-Add-missing-tests-for-GetSubscription.patch (text/plain), 2.08 KB, created by
Jonathan Druart
on 2018-11-01 21:10:02 UTC
(
hide
)
Description:
Bug 15774: Add missing tests for GetSubscription
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2018-11-01 21:10:02 UTC
Size:
2.08 KB
patch
obsolete
>From 7ef448ad7db708a9ec2c6cebe1f9a00b6144a3ff Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 1 Nov 2018 17:54:02 -0300 >Subject: [PATCH] Bug 15774: Add missing tests for GetSubscription > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Serials.t | 29 +++++++++++++++++++++++++++-- > 1 file changed, 27 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t >index 4c0f56a..8304a2e 100755 >--- a/t/db_dependent/Serials.t >+++ b/t/db_dependent/Serials.t >@@ -6,7 +6,6 @@ > use Modern::Perl; > use YAML; > >-use CGI qw ( -utf8 ); > use C4::Serials; > use C4::Serials::Frequency; > use C4::Serials::Numberpattern; >@@ -16,9 +15,11 @@ use C4::Budgets; > use C4::Items; > use Koha::DateUtils; > use Koha::Acquisition::Booksellers; >+use Koha::Subscriptions; >+use Koha::AdditionalFields; > use t::lib::Mocks; > use t::lib::TestBuilder; >-use Test::More tests => 46; >+use Test::More tests => 47; > > BEGIN { > use_ok('C4::Serials'); >@@ -348,6 +349,30 @@ subtest "Do not generate an expected if one already exists" => sub { > is( @serialsByStatus, 1, "ModSerialStatus delete corectly serial expected and not create another if exists" ); > }; > >+subtest 'Addition fields for subscription' => sub { >+ plan tests => 2; >+ >+ is( ref($subscription->{additional_fields}), 'HASH'); # Could be a 'Koha::AdditionalFields! >+ >+ my $subscription_object = Koha::Subscriptions->find($subscriptionid); >+ my $foo = Koha::AdditionalField->new({ >+ tablename => 'subscription', >+ name => 'subscription_foo', >+ })->store; >+ >+ $subscription_object->set_additional_fields( >+ [ >+ { >+ id => $foo->id, >+ value => 'foo value for subscription', >+ } >+ ] >+ ); >+ >+ my $subscription = C4::Serials::GetSubscription($subscriptionid); >+ is( ref($subscription->{additional_fields}), 'HASH', 'GetSubscription should build the additional fields'); # Could be a Koha::AdditionalFieldValues >+}; >+ > $dbh->rollback; > > sub get_biblio { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15774
:
48224
|
53608
|
53609
|
72078
|
72079
|
72085
|
72086
|
75083
|
75084
|
75085
|
75086
|
75336
|
75354
|
75361
|
79976
|
79977
|
79978
|
79979
|
79980
|
79981
|
79982
|
80060
|
80061
|
80062
|
80063
|
80064
|
80065
|
80066
|
80680
|
81490
|
81491
|
81492
|
81493
|
81494
|
81495
|
81496
|
81497
|
81833
|
81837
|
81838
|
81839
|
81840
|
81841
|
81842
|
81843
|
81844
|
81845
|
81846
|
81847
|
81848
|
81849
|
81850
|
81851
|
81852
|
83349
|
83350
|
83351
|
83352
|
83353
|
83354
|
83355
|
83356
|
83357
|
83358
|
83359
|
83360
|
83361
|
83362
|
83363
|
83364
|
83444
|
83445
|
83446
|
83447
|
83448
|
83449
|
83450
|
83451
|
83452
|
83453
|
83454
|
83455
|
83456
|
83457
|
83458
|
83459
|
85333
|
85334
|
85335
|
85336
|
85337
|
85338
|
85339
|
85340
|
85341
|
85342
|
85343
|
85344
|
85345
|
85346
|
85347
|
85348
|
85792
|
85806
|
85807
|
85808
|
85809
|
85810
|
85811
|
85812
|
85813
|
85814
|
85815
|
85816
|
85817
|
85818
|
85819
|
85820
|
85821
|
85822
|
85823
|
85824
|
86411